Bug 2267098

Summary: Review Request: rust-wasmparser - Simple event-driven library for parsing WebAssembly binary files
Product: [Fedora] Fedora Reporter: Aleksei Bavshin <alebastr89>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/wasmparser
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-03-20 03:47:22 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2265406    

Description Aleksei Bavshin 2024-02-29 17:39:48 UTC
Spec URL: https://alebastr.fedorapeople.org/review/rust-wasmparser.spec
SRPM URL: https://alebastr.fedorapeople.org/review/rust-wasmparser-0.201.0-1.fc40.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/alebastr/rust-tree-sitter-cli/build/7157522/

Description:
A simple event-driven library for parsing WebAssembly binary files.

Fedora Account System Username: alebastr

This is an unretirement request for https://src.fedoraproject.org/rpms/rust-wasmparser

Comment 1 Aleksei Bavshin 2024-02-29 17:39:50 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=114245056

Comment 2 Fedora Review Service 2024-02-29 17:43:06 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7092286
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2267098-rust-wasmparser/fedora-rawhide-x86_64/07092286-rust-wasmparser/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fabio Valentini 2024-03-14 16:08:57 UTC
> # * Undeclared dependencies on wasm_encoder, wat, ...

This usually means that dependencies *are* present upstream, but only as "path"-based dependencies, which are stripped when running "cargo publish".
So in this case the tests likely can only be run inside the upstream git repo - disabling them is fine.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
! test suite is run and all unit tests pass (disabled with explanation)
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

(ignore those that don't make sense for unretirements)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 4 Fedora Update System 2024-03-20 03:42:55 UTC
FEDORA-2024-92094a1104 (rust-wasmparser-0.201.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-92094a1104

Comment 5 Fedora Update System 2024-03-20 03:47:22 UTC
FEDORA-2024-92094a1104 (rust-wasmparser-0.201.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.