Bug 2267098 - Review Request: rust-wasmparser - Simple event-driven library for parsing WebAssembly binary files
Summary: Review Request: rust-wasmparser - Simple event-driven library for parsing Web...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/wasmparser
Depends On:
Blocks: 2265406
TreeView+ depends on / blocked
Reported: 2024-02-29 17:39 UTC by Aleksei Bavshin
Modified: 2024-03-20 03:47 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2024-03-20 03:47:22 UTC
Type: ---
decathorpe: fedora-review+

Attachments (Terms of Use)

Description Aleksei Bavshin 2024-02-29 17:39:48 UTC
Spec URL: https://alebastr.fedorapeople.org/review/rust-wasmparser.spec
SRPM URL: https://alebastr.fedorapeople.org/review/rust-wasmparser-0.201.0-1.fc40.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/alebastr/rust-tree-sitter-cli/build/7157522/

A simple event-driven library for parsing WebAssembly binary files.

Fedora Account System Username: alebastr

This is an unretirement request for https://src.fedoraproject.org/rpms/rust-wasmparser

Comment 1 Aleksei Bavshin 2024-02-29 17:39:50 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=114245056

Comment 2 Fedora Review Service 2024-02-29 17:43:06 UTC
Copr build:

Review template:

Please take a look if any issues were found.

This comment was created by the fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fabio Valentini 2024-03-14 16:08:57 UTC
> # * Undeclared dependencies on wasm_encoder, wat, ...

This usually means that dependencies *are* present upstream, but only as "path"-based dependencies, which are stripped when running "cargo publish".
So in this case the tests likely can only be run inside the upstream git repo - disabling them is fine.


Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
! test suite is run and all unit tests pass (disabled with explanation)
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines



Recommended post-import rust-sig tasks:

(ignore those that don't make sense for unretirements)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 4 Fedora Update System 2024-03-20 03:42:55 UTC
FEDORA-2024-92094a1104 (rust-wasmparser-0.201.0-1.fc41) has been submitted as an update to Fedora 41.

Comment 5 Fedora Update System 2024-03-20 03:47:22 UTC
FEDORA-2024-92094a1104 (rust-wasmparser-0.201.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.