Bug 2268261
| Summary: | Review Request: kf5-qqc2-desktop-style - QtQuickControls2 style for consistency between QWidget and QML apps | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Yaakov Selkowitz <yselkowi> | ||||
| Component: | Package Review | Assignee: | Alessandro Astone <ales.astone> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | ales.astone, package-review | ||||
| Target Milestone: | --- | Flags: | ales.astone:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://invent.kde.org/frameworks/%{framework} | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2024-03-27 00:15:11 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Yaakov Selkowitz
2024-03-06 20:25:11 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7113608 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2268261-kf5-qqc2-desktop-style/fedora-rawhide-x86_64/07113608-kf5-qqc2-desktop-style/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Taking the review.
This also needs the `Provides:` with %{?_isa} suffix, since packages are currently depending on `qqc2-desktop-style%{?_isa}`
Updated the Provides. The license field does not match the licenses actually used. Looks like it should be: `LGPL-2.0-or-later AND LGPL-2.1-or-later AND (LGPL-3.0-only OR GPL-2.0-or-later) AND (LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only)` Spec URL: https://yselkowitz.fedorapeople.org/kf5-qqc2-desktop-style.spec SRPM URL: https://yselkowitz.fedorapeople.org/kf5-qqc2-desktop-style-5.115.0-2.fc41.src.rpm Description: This is a rename from qqc2-desktop-style, as this is officially a KDE framework, and for consistency with kf6-qqc2-desktop-style which was added for KF6. Fedora Account System Username: yselkowitz (In reply to Alessandro Astone from comment #4) > The license field does not match the licenses actually used. > Looks like it should be: `LGPL-2.0-or-later AND LGPL-2.1-or-later AND > (LGPL-3.0-only OR GPL-2.0-or-later) AND (LGPL-3.0-only OR GPL-2.0-only OR > GPL-3.0-only)` Modified except for LGPL-2.1-or-later, which I don't see anywhere in the sources. Created attachment 2023580 [details]
The .spec file difference from Copr build 7113608 to 7214785
Copr build: https://copr.fedorainfracloud.org/coprs/build/7214785 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2268261-kf5-qqc2-desktop-style/fedora-rawhide-x86_64/07214785-kf5-qqc2-desktop-style/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package approved. The Pagure repository was created at https://src.fedoraproject.org/rpms/kf5-qqc2-desktop-style FEDORA-2024-b9eec243fd (kf5-qqc2-desktop-style-5.115.0-2.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-b9eec243fd FEDORA-2024-b9eec243fd (kf5-qqc2-desktop-style-5.115.0-2.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |