Bug 2268261 - Review Request: kf5-qqc2-desktop-style - QtQuickControls2 style for consistency between QWidget and QML apps
Summary: Review Request: kf5-qqc2-desktop-style - QtQuickControls2 style for consisten...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Alessandro Astone
QA Contact: Fedora Extras Quality Assurance
URL: https://invent.kde.org/frameworks/%{f...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-03-06 20:25 UTC by Yaakov Selkowitz
Modified: 2024-03-27 00:15 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-03-27 00:15:11 UTC
Type: ---
Embargoed:
ales.astone: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 7113608 to 7214785 (807 bytes, patch)
2024-03-26 01:39 UTC, Fedora Review Service
no flags Details | Diff

Description Yaakov Selkowitz 2024-03-06 20:25:11 UTC
Spec URL: https://yselkowitz.fedorapeople.org/kf5-qqc2-desktop-style.spec
SRPM URL: https://yselkowitz.fedorapeople.org/kf5-qqc2-desktop-style-5.115.0-2.fc41.src.rpm
Description: This is a rename from qqc2-desktop-style, as this is officially a KDE framework, and for consistency with kf6-qqc2-desktop-style which was added for KF6.
Fedora Account System Username: yselkowitz

Comment 1 Fedora Review Service 2024-03-06 20:27:30 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7113608
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2268261-kf5-qqc2-desktop-style/fedora-rawhide-x86_64/07113608-kf5-qqc2-desktop-style/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Alessandro Astone 2024-03-06 20:51:51 UTC
Taking the review.

This also needs the `Provides:` with %{?_isa} suffix, since packages are currently depending on `qqc2-desktop-style%{?_isa}`

Comment 3 Yaakov Selkowitz 2024-03-06 20:59:58 UTC
Updated the Provides.

Comment 4 Alessandro Astone 2024-03-06 21:18:08 UTC
The license field does not match the licenses actually used.
Looks like it should be: `LGPL-2.0-or-later AND LGPL-2.1-or-later AND (LGPL-3.0-only OR GPL-2.0-or-later) AND (LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only)`

Comment 5 Yaakov Selkowitz 2024-03-26 01:36:35 UTC
Spec URL: https://yselkowitz.fedorapeople.org/kf5-qqc2-desktop-style.spec
SRPM URL: https://yselkowitz.fedorapeople.org/kf5-qqc2-desktop-style-5.115.0-2.fc41.src.rpm
Description: This is a rename from qqc2-desktop-style, as this is officially a KDE framework, and for consistency with kf6-qqc2-desktop-style which was added for KF6.
Fedora Account System Username: yselkowitz

Comment 6 Yaakov Selkowitz 2024-03-26 01:37:17 UTC
(In reply to Alessandro Astone from comment #4)
> The license field does not match the licenses actually used.
> Looks like it should be: `LGPL-2.0-or-later AND LGPL-2.1-or-later AND
> (LGPL-3.0-only OR GPL-2.0-or-later) AND (LGPL-3.0-only OR GPL-2.0-only OR
> GPL-3.0-only)`

Modified except for LGPL-2.1-or-later, which I don't see anywhere in the sources.

Comment 7 Fedora Review Service 2024-03-26 01:39:05 UTC
Created attachment 2023580 [details]
The .spec file difference from Copr build 7113608 to 7214785

Comment 8 Fedora Review Service 2024-03-26 01:39:08 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7214785
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2268261-kf5-qqc2-desktop-style/fedora-rawhide-x86_64/07214785-kf5-qqc2-desktop-style/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 9 Alessandro Astone 2024-03-26 10:50:00 UTC
Package approved.

Comment 10 Fedora Admin user for bugzilla script actions 2024-03-26 11:25:52 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/kf5-qqc2-desktop-style

Comment 11 Fedora Update System 2024-03-26 13:45:37 UTC
FEDORA-2024-b9eec243fd (kf5-qqc2-desktop-style-5.115.0-2.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-b9eec243fd

Comment 12 Fedora Update System 2024-03-27 00:15:11 UTC
FEDORA-2024-b9eec243fd (kf5-qqc2-desktop-style-5.115.0-2.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.