Bug 2268679

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7129672
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2268679-python-cmap/fedora-rawhide-x86_64/07129672-python-cmap/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

After some discussion with upstream we came up with a different patch for the tests.

Spec URL: https://gui1ty.fedorapeople.org/review/python-cmap.spec
SRPM URL: https://gui1ty.fedorapeople.org/review/python-cmap-0.2.0-2.fc41.src.rpm

Created attachment 2020825 [details]
The .spec file difference from Copr build 7129672 to 7129688

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7129688
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2268679-python-cmap/fedora-rawhide-x86_64/07129688-python-cmap/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Hi Sandro,
 is there a reason to be using the development version and not the stable release?

Is that due to the test issue that you identified above.

Because that is only reason where fedora-review rightly complains:
- Sources used to build the package match the upstream source, as provided
  in the spec URL.

The difference is related with changes introduced upstream, while your original package used a previous commit.
The patch is not applied because it is already applied upstream.

Other than that this is a simple python package. The licenses are correct and admissible on Fedora and the package follows the Fedora package guidelines for Python packages.

Please fix the source issue on import.

(In reply to José Matos from comment #5)
> Hi Sandro,
>  is there a reason to be using the development version and not the stable
> release?

I anticipated version 0.2.0 is going to be released soon since the tag was present already. Upstream confirmed that [1] in the discussion regarding my PR (#39), which evolved into PR #40, which is the patch applied.

> Is that due to the test issue that you identified above.
> 
> Because that is only reason where fedora-review rightly complains:
> - Sources used to build the package match the upstream source, as provided
>   in the spec URL.

I'm not seeing any complaint. For rawhide and F40 there's no template generated. Looking at the F38 template [2] I see:

[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.

That's a pass.

I guess you ran fedora-review after review service.

> The difference is related with changes introduced upstream, while your
> original package used a previous commit.
> The patch is not applied because it is already applied upstream.

I guess upstream may have moved the tag. Very naughty, but permissible, I suppose, since it wasn't officially released. They mentioned releasing after PR #40 was merged.
 
> Other than that this is a simple python package. The licenses are correct
> and admissible on Fedora and the package follows the Fedora package
> guidelines for Python packages.
> 
> Please fix the source issue on import.

I'll do that.

Spec URL: https://gui1ty.fedorapeople.org/review/python-cmap.spec
SRPM URL: https://gui1ty.fedorapeople.org/review/python-cmap-0.2.0-3.fc41.src.rpm


[1] https://github.com/tlambert03/cmap/pull/39#discussion_r1518611308
[2] https://download.copr.fedorainfracloud.org/results/%40fedora-review/fedora-review-2268679-python-cmap/fedora-38-x86_64/07129688-python-cmap/fedora-review/review.txt

The Pagure repository was created at https://src.fedoraproject.org/rpms/python-cmap

FEDORA-2024-c93f42c148 (python-cmap-0.2.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-c93f42c148

FEDORA-2024-c93f42c148 (python-cmap-0.2.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2024-c552c1b9fd (python-cmap-0.2.0-1.fc40, python-pyconify-0.1.6-1.fc40, and 5 more) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-c552c1b9fd

FEDORA-2024-c552c1b9fd has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-c552c1b9fd \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-c552c1b9fd

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-c552c1b9fd (python-cmap-0.2.0-1.fc40, python-pyconify-0.1.6-1.fc40, and 5 more) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.