Bug 2269893
| Summary: | Review Request: golang-github-makeworld-the-better-one-dither2 - A fast, correct image dithering library in Go | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | W. Michael Petullo <mike> |
| Component: | Package Review | Assignee: | Mikel Olasagasti Uranga <mikel> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mikel, package-review |
| Target Milestone: | --- | Flags: | mikel:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-03-17 20:32:18 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2209669 | ||
|
Description
W. Michael Petullo
2024-03-16 23:03:37 UTC
Spec name is not correct. $ go2rpm github.com/makeworld-the-better-one/dither/v2 -f https://github.com/makew0rld/dither/ --print-name golang-github-makeworld-the-better-one-dither2 Please, rename the BZ and spec to golang-github-makeworld-the-better-one-dither2. Other than that, the spec is correct. Spec URL: https://www.flyn.org/SRPMS/golang-github-makeworld-the-better-one-dither2.spec SRPM URL: https://www.flyn.org/SRPMS/golang-github-makeworld-the-better-one-dither2-2.4.0-1.fc39.src.rpm I am not going to go through the whole fedora-review template, as this package uses go2rpm. - [x] The specfile is sane. - [x] License is correct - [x] Builds successfully in mock - [x] Package is installable (checked by fedora-review) - [x] No relevant rpmlint errors - [x] %check section passes - [x] The latest version is packaged - [x] `%goipath` is set correctly - [-] Binaries don't conflict with binaries already in the distribution - [x] The package complies with the Packaging Guidelines. Package approved! On import, don't forget to do the following: - [ ] Add package to release-monitoring.org - [ ] Give go-sig privileges on package - [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket. The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-makeworld-the-better-one-dither2 FEDORA-2024-c9a40e899d (golang-github-makeworld-the-better-one-dither2-2.4.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-c9a40e899d FEDORA-2024-c9a40e899d (golang-github-makeworld-the-better-one-dither2-2.4.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. There seems to be some problem with the following file. SRPM URL: https://www.flyn.org/SRPMS/golang-github-makeworld-the-better-one-dither-2.4.0-1.fc39.src.rpm Fetching it results in a 404 Not Found error. Please make sure the URL is correct and publicly available. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. |