Bug 2269893 - Review Request: golang-github-makeworld-the-better-one-dither2 - A fast, correct image dithering library in Go
Summary: Review Request: golang-github-makeworld-the-better-one-dither2 - A fast, corr...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mikel Olasagasti Uranga
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2209669
TreeView+ depends on / blocked
 
Reported: 2024-03-16 23:03 UTC by W. Michael Petullo
Modified: 2024-03-17 21:55 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-03-17 20:32:18 UTC
Type: ---
Embargoed:
mikel: fedora-review+


Attachments (Terms of Use)

Description W. Michael Petullo 2024-03-16 23:03:37 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-github-makeworld-the-better-one-dither.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-github-makeworld-the-better-one-dither-2.4.0-1.fc39.src.rpm
Description: A fast, correct image dithering library in Go
Fedora Account System Username: mikep

Comment 3 Mikel Olasagasti Uranga 2024-03-17 19:15:08 UTC
Spec name is not correct.

$ go2rpm github.com/makeworld-the-better-one/dither/v2 -f https://github.com/makew0rld/dither/ --print-name
golang-github-makeworld-the-better-one-dither2

Please, rename the BZ and spec to golang-github-makeworld-the-better-one-dither2.

Other than that, the spec is correct.

Comment 5 Mikel Olasagasti Uranga 2024-03-17 20:08:12 UTC
I am not going to go through the whole fedora-review template, as this package uses go2rpm.

- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No relevant rpmlint errors
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [-] Binaries don't conflict with binaries already in the distribution
- [x] The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add package to release-monitoring.org
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.

Comment 6 Fedora Admin user for bugzilla script actions 2024-03-17 20:19:23 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-makeworld-the-better-one-dither2

Comment 7 Fedora Update System 2024-03-17 20:29:02 UTC
FEDORA-2024-c9a40e899d (golang-github-makeworld-the-better-one-dither2-2.4.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-c9a40e899d

Comment 8 Fedora Update System 2024-03-17 20:32:18 UTC
FEDORA-2024-c9a40e899d (golang-github-makeworld-the-better-one-dither2-2.4.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Review Service 2024-03-17 21:55:26 UTC
There seems to be some problem with the following file.
SRPM URL: https://www.flyn.org/SRPMS/golang-github-makeworld-the-better-one-dither-2.4.0-1.fc39.src.rpm
Fetching it results in a 404 Not Found error.
Please make sure the URL is correct and publicly available.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


Note You need to log in before you can comment on or make changes to this bug.