Bug 2270287

Summary:	Review Request: rust-async_zip - Asynchronous ZIP archive reading/writing crate
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	Arthur Bols <arthur>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	arthur, germano.massullo, package-review
Target Milestone:	---	Keywords:	AutomationTriaged
Target Release:	---	Flags:	arthur: fedora-review+
Hardware:	Unspecified
OS:	Unspecified
URL:	https://crates.io/crates/async_zip
Whiteboard:
Fixed In Version:	rust-async_zip-0.0.17-1.fc41	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-04-15 14:23:02 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Fabio Valentini 2024-03-19 12:47:10 UTC

Spec URL: https://decathorpe.fedorapeople.org/rust-async_zip.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-async_zip-0.0.16-1.fc39.src.rpm

Description:
An asynchronous ZIP archive reading/writing crate.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2024-03-19 12:47:13 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=115162804

Comment 2 Fedora Review Service 2024-03-19 13:12:49 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7182794
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2270287-rust-async_zip/fedora-rawhide-x86_64/07182794-rust-async_zip/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Arthur Bols 2024-03-23 10:38:03 UTC

Package was largely generated with rust2rpm, simplifying the review.

[x]: package builds and installs without errors on rawhide
[x]: patch looks sane and is justified
[x]: test suite is run and all unit tests pass
[x]: latest version of the crate is packaged
[x]: license matches upstream specification and is acceptable for Fedora
[x]: licenses of statically linked dependencies are correctly taken into account
[x]: license file is included with %license in %files
[x]: package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 4 Fabio Valentini 2024-04-15 13:07:02 UTC

Thank you for the review!

Comment 5 Fabio Valentini 2024-04-15 14:23:02 UTC

Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2024-5f72da7429