Bug 227068
| Summary: | Review Request: jaxen-1.1-0.b7.4jpp - An XPath engine written in Java | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rafael H. Schloming <rafaels> | ||||
| Component: | Package Review | Assignee: | Jeff Johnston <jjohnstn> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | dbhole, overholt, pbrobinson, tross, viveklak | ||||
| Target Milestone: | --- | Flags: | jjohnstn:
fedora-review+
wtogami: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2008-10-11 14:15:20 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 227109 | ||||||
| Attachments: |
|
||||||
|
Description
Rafael H. Schloming
2007-02-02 17:40:27 UTC
Updated spec and SRPM: http://overholt.ca/fedora/jaxen.spec http://overholt.ca/fedora/jaxen-1.1-1jpp.1.src.rpm MUST:
X - remove defines at start for name, version, release and fill in tags
X rpmlint on <this package>.srpm gives no output
W: jaxen unversioned-explicit-provides jaxen-bootstrap
W: jaxen unversioned-explicit-obsoletes jaxen-bootstrap
W: jaxen mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 44)
X package successfully compiles and builds on at least x86
- requires packages not available yet
- mock build failed
X make sure lines are <= 80 characters
- one comment goes over
X remove %ghost
- use %{_javadocdir}/*
X verify the final provides and requires of the binary RPMs
- could not build
X run rpmlint on the binary RPMs
- still needs to be done
Updated spec and SRPM: http://overholt.ca/fedora/jaxen.spec http://overholt.ca/fedora/jaxen-1.1-1jpp.1.src.rpm (In reply to comment #2) > MUST: > X - remove defines at start for name, version, release and fill in tags Fixed. > W: jaxen unversioned-explicit-provides jaxen-bootstrap > W: jaxen unversioned-explicit-obsoletes jaxen-bootstrap Fixed, fixed. > W: jaxen mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 44) Fixed. > X make sure lines are <= 80 characters > - one comment goes over Fixed. > X remove %ghost > - use %{_javadocdir}/* Fixed. Please just use %{_javadocdir}/* in %files section for javadoc.
(In reply to comment #4) > Please just use %{_javadocdir}/* in %files section for javadoc. Fixed. Updated spec and SRPM: http://overholt.ca/fedora/jaxen.spec http://overholt.ca/fedora/jaxen-1.1-1jpp.1.src.rpm Approved. New Package CVS Request ======================= Package Name: jaxen Short Description: An XPath engine written in Java Owners: vivekl Branches: InitialCC: Reassigning to main reviewer. The specified srpm does not build in mock. Was the srpm changed since approval? My bad for not reverifying this. I had originally noted in the review that the package did not build and had assumed that the fixes had dealt with this. Moving back to review -. Try this one: http://overholt.ca/fedora/jaxen.spec http://overholt.ca/fedora/jaxen-1.1-1jpp.1.src.rpm The one I just posted builds for me in mock: http://overholt.ca/fedora/jaxen.spec http://overholt.ca/fedora/jaxen-1.1-1jpp.1.src.rpm Jeff, can you verify and re-+ the review? Ok. Verified to build under mock. I have changed back to + review. Created attachment 150458 [details]
Build failure log
I get the attached failure when I try to build on rawhide.
(In reply to comment #14) > Created an attachment (id=150458) [edit] > Build failure log > > I get the attached failure when I try to build on rawhide. > Hi Anthony, Thanks for the info. Looks like we avoided/failed to notice the problem in the plague build since ant-junit was not a BR, which made it skip all the tests: http://buildsys.fedoraproject.org/logs/fedora-development-extras/29714-jaxen-1.1-1jpp.1.fc7/noarch/build.log I will add the missing BR and try to debug the problem. (In reply to comment #14) > Created an attachment (id=150458) [edit] > Build failure log > > I get the attached failure when I try to build on rawhide. > I just rebuilt jaxen on plague with the missing ant-junit and the build succeeded (this time it ran the unit tests): http://buildsys.fedoraproject.org/logs/fedora-development-extras/30495-jaxen-1.1-1jpp.2.fc7/noarch/build.log So I guess the problem is fixed. Reassigning to Jeff (main reviewer) so he can close the bug after verifying that the package has hit rawhide. Shouldn't this have been closed a long time ago? Closing - in rawhide |