Hide Forgot
Spec URL: http://people.redhat.com/rafaels/specs/pmd-3.6-1jpp.spec SRPM URL: ftp://jpackage.hmdc.harvard.edu/JPackage/1.7/generic/SRPMS.free/pmd-3.6-1jpp.src.rpm Description: PMD scans Java source code and looks for potential problems like: + Unused local variables + Empty catch blocks + Unused parameters + Empty 'if' statements + Duplicate import statements + Unused private methods + Classes which could be Singletons + Short/long variable and method names PMD has plugins for JDeveloper, JEdit, JBuilder, NetBeans/Sun ONE Studio, IntelliJ IDEA, TextPad, Maven, Ant, Eclipse, Gel, and Emacs. Documentation for pmd. Javadoc for pmd.
All problems below taken care of except binary build which is blocked due to jaxen requirement. http://www.vermillionskye.com/downloads/pmd-3.6-1jpp.1.src.rpm http://www.vermillionskye.com/downloads/pmd.spec MUST: X - remove defines at top - fill in Name, Version, and Release fields Fixed. X - release should be of form Xjpp.Y%{?dist} Fixed. X - instructions for source tar are incomplete Fixed. X - checking out source from CVS as specified and tarring does not result in same md5sum Fixed. Source replaced. X correct buildroot - should be: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) Fixed. X Vendor tag should not be used Fixed. X Distribution tag should not be used Fixed. X package successfully compiles and builds on at least x86 - waiting on jaxen X make sure lines are <= 80 characters Fixed. X run rpmlint on the src RPMs W: pmd non-standard-group Development/Testing E: pmd no-cleaning-of-buildroot %install W: pmd mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 30) Fixed.
Small remaining issues: . Get rid of the double hash marks - just use single ones . Get rid of the cvs login - it's unnecessary I can't duplicate the md5sum of the generated source tarball but a recursive diff on the expanded contents shows no differences. I've added the blocker on jaxen. Everything else is fine. Thanks.
Fixes made. http://www.vermillionskye.com/downloads/pmd-3.6-1jpp.1.src.rpm http://www.vermillionskye.com/downloads/pmd.spec
Approved! Thanks, Jeff.
New Package CVS Request ======================= Package Name: pmd Short Description: Scans Java source code and looks for potential problems Owners: mwringe@redhat.com Branches: devel
This package does not build in mock: http://people.redhat.com/dbhole/fedora/pmd/build.log
Fixed a BR. New spec and srpm: http://people.redhat.com/dbhole/fedora/pmd/