Bug 227071
| Summary: | Review Request: jline-0.9.9-1jpp - Java library for reading and editing user input in console applications | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rafael H. Schloming <rafaels> |
| Component: | Package Review | Assignee: | Matt Wringe <mwringe> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dpierce, tross |
| Target Milestone: | --- | Flags: | tbento:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-03-13 14:37:07 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Rafael H. Schloming
2007-02-02 17:41:19 UTC
Update srpm and spec file: https://mwringe.108.redhat.com/files/documents/175/266/jline-0.9.9-1jpp.1.src.rpm https://mwringe.108.redhat.com/files/documents/175/265/jline.spec Just a couple things: - Should the post and postun sections for javadoc be removed? - Some lines have more than 80 characters. - Should gcj support be added? - I think group should be changed to Development/Libraries. (In reply to comment #2) > Just a couple things: > > - Should the post and postun sections for javadoc be removed? They have been removed, I didn't remove them before since we have hard coded the srpm to use ant instead of maven (and the ant build doesn't have javadocs) > - Some lines have more than 80 characters. I believe only the description has to be less than 80 characters per line, which it is. If this is not the case let me know. > - Should gcj support be added? I added gcj support. > - I think group should be changed to Development/Libraries. Groups are ignored by fedora so they shouldn't matter. But since this causes an issue with rpmlint, I have changed it. https://mwringe.108.redhat.com/files/documents/175/265/jline.spec https://mwringe.108.redhat.com/files/documents/175/266/jline-0.9.9-1jpp.1.src.rpm > > - Should gcj support be added?
>
> I added gcj support.
I think that _with_gcj_support should be set to 1.
(In reply to comment #4) > > > - Should gcj support be added? > > > > I added gcj support. > > I think that _with_gcj_support should be set to 1. done https://mwringe.108.redhat.com/files/documents/175/287/jline.spec https://mwringe.108.redhat.com/files/documents/175/288/jline-0.9.9-1jpp.1.src.rpm This looks good to me. Approving it. New Package CVS Request ======================= Package Name: jline Short Description: Java library for reading and editing user input in console applications Owners: mwringe Branches: devel InitialCC: Package Change Request ====================== Package Name: jline New Branches: epel7 Owners: mcpierce Git done (by process-git-requests). |