Bug 227071 - Review Request: jline-0.9.9-1jpp - Java library for reading and editing user input in console applications
Review Request: jline-0.9.9-1jpp - Java library for reading and editing user ...
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Matt Wringe
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-02-02 12:41 EST by Rafael H. Schloming
Modified: 2014-12-01 18:13 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-03-13 10:37:07 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
tbento: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Rafael H. Schloming 2007-02-02 12:41:19 EST
Spec URL: http://people.redhat.com/rafaels/specs/jline-0.9.9-1jpp.spec
SRPM URL: ftp://jpackage.hmdc.harvard.edu/JPackage/1.7/generic/SRPMS.free/jline-0.9.9-1jpp.src.rpm
Description: JLine is a java library for reading and editing user input in console
applications. It features tab-completion, command history, password
masking, customizable keybindings, and pass-through handlers to use to
chain to other console applications.

Demonstrations and samples for jline.

Javadoc for jline.
Comment 2 Tania Bento 2007-03-06 12:51:02 EST
Just a couple things:

- Should the post and postun sections for javadoc be removed?
- Some lines have more than 80 characters.
- Should gcj support be added?
- I think group should be changed to Development/Libraries.
Comment 3 Matt Wringe 2007-03-07 11:19:43 EST
(In reply to comment #2)
> Just a couple things:
> 
> - Should the post and postun sections for javadoc be removed?

They have been removed, I didn't remove them before since we have hard coded the
srpm to use ant instead of maven (and the ant build doesn't have javadocs)

> - Some lines have more than 80 characters.

I believe only the description has to be less than 80 characters per line, which
it is. If this is not the case let me know.

> - Should gcj support be added?

I added gcj support.

> - I think group should be changed to Development/Libraries.

Groups are ignored by fedora so they shouldn't matter. But since this causes an
issue with rpmlint, I have changed it.

https://mwringe.108.redhat.com/files/documents/175/265/jline.spec
https://mwringe.108.redhat.com/files/documents/175/266/jline-0.9.9-1jpp.1.src.rpm
Comment 4 Tania Bento 2007-03-09 10:18:07 EST
> > - Should gcj support be added?
> 
> I added gcj support.

I think that _with_gcj_support should be set to 1.

Comment 5 Matt Wringe 2007-03-12 10:32:50 EDT
(In reply to comment #4)
> > > - Should gcj support be added?
> > 
> > I added gcj support.
> 
> I think that _with_gcj_support should be set to 1.

done

https://mwringe.108.redhat.com/files/documents/175/287/jline.spec
https://mwringe.108.redhat.com/files/documents/175/288/jline-0.9.9-1jpp.1.src.rpm

Comment 6 Tania Bento 2007-03-12 17:21:28 EDT
This looks good to me.  Approving it.
Comment 7 Matt Wringe 2007-03-12 17:24:01 EDT
New Package CVS Request
=======================
Package Name: jline
Short Description: Java library for reading and editing user input in console
applications
Owners: mwringe@redhat.com
Branches: devel
InitialCC: 
Comment 8 Darryl L. Pierce 2014-09-03 09:42:32 EDT
Package Change Request
======================
Package Name: jline
New Branches: epel7
Owners: mcpierce
Comment 9 Gwyn Ciesla 2014-09-03 09:51:03 EDT
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.