Bug 2271120
| Summary: | Review Request: rust-path-clean - Rust implementation of cleanname or path.Clean | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Arthur Bols <arthur> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | decathorpe:
fedora-review?
|
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/path-clean | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-06-04 12:53:35 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2262203 | ||
|
Description
Arthur Bols
2024-03-22 20:21:37 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7202793 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2271120-rust-path-clean/fedora-rawhide-x86_64/07202793-rust-path-clean/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Added comment for patch Spec URL: https://principis.fedorapeople.org/rust-path-clean.spec SRPM URL: https://principis.fedorapeople.org/rust-path-clean-1.0.1-1.fc41.src.rpm Package looks good, with a minor issue. The LICENSE-APACHE file only contains the license header, not the actual license text for Apache-2.0. The full text is required to be included in redistributed sources. Please report this as an upstream issue. Thanks! Opened an issue upstream and added the correct license in the spec. Spec URL: https://principis.fedorapeople.org/rust-path-clean.spec SRPM URL: https://principis.fedorapeople.org/rust-path-clean-1.0.1-1.fc41.src.rpm Upstream issue: https://github.com/danreeves/path-clean/issues/15 Thanks! Can you use the URL to upstream license file instead of plain file name? Something like this should do it: """ # Missing Apache license: https://github.com/danreeves/path-clean/issues/15 Source1: https://github.com/danreeves/path-clean/raw/3876d7c/LICENSE-APACHE """ I resubmitted this package myself because this review seems to be stalled. *** This bug has been marked as a duplicate of bug 2290369 *** |