Bug 2290369 - Review Request: rust-path-clean - Rust implementation of cleanname or path.Clean
Summary: Review Request: rust-path-clean - Rust implementation of cleanname or path.Clean
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: wojnilowicz
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/path-clean
Whiteboard:
: 2271120 (view as bug list)
Depends On:
Blocks: 2262203
TreeView+ depends on / blocked
 
Reported: 2024-06-04 12:51 UTC by Fabio Valentini
Modified: 2024-06-13 20:17 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-06-13 20:17:26 UTC
Type: ---
Embargoed:
lukasz.wojnilowicz: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2024-06-04 12:51:19 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-path-clean.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-path-clean-1.0.1-1.fc40.src.rpm

Description:
A Rust implementation of cleanname or path.Clean.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2024-06-04 12:51:22 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=118555474

Comment 2 Fabio Valentini 2024-06-04 12:53:35 UTC
*** Bug 2271120 has been marked as a duplicate of this bug. ***

Comment 3 Fedora Review Service 2024-06-04 12:58:33 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7528506
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2290369-rust-path-clean/fedora-rawhide-x86_64/07528506-rust-path-clean/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 wojnilowicz 2024-06-10 17:04:06 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files (APACHE license included manually from upstream, PR to add them was accepted)
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

Comment 5 Fabio Valentini 2024-06-13 13:58:23 UTC
Thank you for the review!

Comment 6 Fedora Admin user for bugzilla script actions 2024-06-13 14:02:02 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-path-clean

Comment 7 Fedora Update System 2024-06-13 15:48:53 UTC
FEDORA-2024-05463ff387 (rust-ansi-width-0.1.0-1.fc41, rust-eza-0.18.11-1.fc41, and 3 more) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-05463ff387

Comment 8 Fedora Update System 2024-06-13 20:17:26 UTC
FEDORA-2024-05463ff387 (rust-ansi-width-0.1.0-1.fc41, rust-eza-0.18.11-1.fc41, and 3 more) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.