Bug 2271122
| Summary: | Review Request: rust-ansi-width - Calculate the width of a string when printed to the terminal | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Arthur Bols <arthur> | ||||
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> | ||||
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | decathorpe, package-review | ||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||
| Target Release: | --- | Flags: | decathorpe:
fedora-review+
|
||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://crates.io/crates/ansi-width | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: |
If this bug requires documentation, please select an appropriate Doc Type value.
|
|||||
| Last Closed: | 2024-06-04 12:53:22 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 2262203, 2263515 | ||||||
| Attachments: |
|
||||||
|
Description
Arthur Bols
2024-03-22 20:39:32 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7202823 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2271122-rust-ansi-width/fedora-rawhide-x86_64/07202823-rust-ansi-width/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Upstreamed patch: https://github.com/uutils/ansi-width/pull/6 Spec URL: https://principis.fedorapeople.org/rust-ansi-width.spec SRPM URL: https://principis.fedorapeople.org/rust-ansi-width-0.1.0-1.fc41.src.rpm Created attachment 2023169 [details]
The .spec file difference from Copr build 7202823 to 7202954
Copr build: https://copr.fedorainfracloud.org/coprs/build/7202954 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2271122-rust-ansi-width/fedora-rawhide-x86_64/07202954-rust-ansi-width/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Looks good to me, just one small thing: When patching Cargo.toml, the only supported way to do this is correctly via "rust2rpm -p". Changes to Cargo.toml affect the generated spec file, so they need to happen *before* the spec file is written. Thanks. I renamed the patch to clarify it's upstreamed, so it's still generated using `rust2rpm -p`. I guess this could be more confusing, I replaced it with a comment. Spec URL: https://principis.fedorapeople.org/rust-ansi-width.spec SRPM URL: https://principis.fedorapeople.org/rust-ansi-width-0.1.0-1.fc41.src.rpm Sorry for the delay. Package looks good to me, thank you! === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) I resubmitted this package myself because this review seems to be stalled. *** This bug has been marked as a duplicate of bug 2290370 *** |