Spec URL: https://principis.fedorapeople.org/rust-ansi-width.spec SRPM URL: https://principis.fedorapeople.org/rust-ansi-width-0.1.0-1.fc41.src.rpm Description: Calculate the width of a string when printed to the terminal. Fedora Account System Username: principis
Copr build: https://copr.fedorainfracloud.org/coprs/build/7202823 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2271122-rust-ansi-width/fedora-rawhide-x86_64/07202823-rust-ansi-width/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Upstreamed patch: https://github.com/uutils/ansi-width/pull/6 Spec URL: https://principis.fedorapeople.org/rust-ansi-width.spec SRPM URL: https://principis.fedorapeople.org/rust-ansi-width-0.1.0-1.fc41.src.rpm
Created attachment 2023169 [details] The .spec file difference from Copr build 7202823 to 7202954
Copr build: https://copr.fedorainfracloud.org/coprs/build/7202954 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2271122-rust-ansi-width/fedora-rawhide-x86_64/07202954-rust-ansi-width/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Looks good to me, just one small thing: When patching Cargo.toml, the only supported way to do this is correctly via "rust2rpm -p". Changes to Cargo.toml affect the generated spec file, so they need to happen *before* the spec file is written.
Thanks. I renamed the patch to clarify it's upstreamed, so it's still generated using `rust2rpm -p`. I guess this could be more confusing, I replaced it with a comment. Spec URL: https://principis.fedorapeople.org/rust-ansi-width.spec SRPM URL: https://principis.fedorapeople.org/rust-ansi-width-0.1.0-1.fc41.src.rpm
Sorry for the delay. Package looks good to me, thank you! === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)