Bug 2272373

Summary:	Review Request: golang-facette-natsort - Natural strings sorting in Go
Product:	[Fedora] Fedora	Reporter:	Sergey Abroskin <merdedok>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	NEW ---	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	mikel, package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	177841, 2272374

Description Sergey Abroskin 2024-03-31 13:11:15 UTC

Spec URL: https://copr-be.cloud.fedoraproject.org/results/merded/kubectx/srpm-builds/07239559/golang-facette-natsort.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/merded/kubectx/srpm-builds/07239559/golang-facette-natsort-0-0.1.20240331git2cd4dd1.fc41.src.rpm
Description: Natural strings sorting in Go
Fedora Account System Username: merded

Comment 1 Mikel Olasagasti Uranga 2024-04-03 21:56:15 UTC

> %gometa -f

Why `-L` is removed?

Comment 2 Sergey Abroskin 2024-04-03 22:23:00 UTC

Spec URL: https://copr-be.cloud.fedoraproject.org/results/merded/kubectx/srpm-builds/07255285/golang-facette-natsort.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/merded/kubectx/srpm-builds/07255285/golang-facette-natsort-0-0.1.20240331git2cd4dd1.fc41.src.rpm

Comment 3 Mikel Olasagasti Uranga 2024-04-13 11:36:51 UTC

Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance

Thanks!

Comment 4 Package Review 2025-05-03 09:49:35 UTC

Package was never imported.
The ticket status is being reset, since creating the repository will require a fresh approval.
Let us know if you're still interested in this package.