Bug 2272373 - Review Request: golang-facette-natsort - Natural strings sorting in Go
Summary: Review Request: golang-facette-natsort - Natural strings sorting in Go
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Mikel Olasagasti Uranga
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: FE-NEEDSPONSOR 2272374
TreeView+ depends on / blocked
Reported: 2024-03-31 13:11 UTC by Sergey Abroskin
Modified: 2024-04-13 11:36 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed:
Type: ---
mikel: fedora-review+

Attachments (Terms of Use)

Comment 1 Mikel Olasagasti Uranga 2024-04-03 21:56:15 UTC
> %gometa -f

Why `-L` is removed?

Comment 3 Mikel Olasagasti Uranga 2024-04-13 11:36:51 UTC
Golang Package Review

This package was generated using go2rpm, which simplifies the review.

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance


Note You need to log in before you can comment on or make changes to this bug.