Bug 2273353
| Summary: | Review Request: mailman3-fedmsg-plugin-schemas - Fedora Messaging schema for messages emitted by Mailman 3 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michal Konecny <mkonecny> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ngompa13, package-review |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-04-05 12:27:13 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Michal Konecny
2024-04-04 11:34:37 UTC
Taking this review. Initial spec review: > License: GPL-3.0-or-later This appears to be the wrong license. The metadata and the repository indicate LGPL-3.0-or-later. > URL: https://pypi.python.org/pypi/mailman3-fedmsg-plugin-schemas This should be something that *isn't* PyPI. I updated the license to correct one (I must have just missed that) and changed the URL to GitHub repository. Here are the updated Spec and SRPM: Spec URL: https://zlopez.fedorapeople.org/mailman3-fedmsg-plugin-schemas.spec SRPM URL: https://zlopez.fedorapeople.org/mailman3-fedmsg-plugin-schemas-1.0.0-1.el9.src.rpm Review notes: * Package follows Fedora Packaging Guidelines * Package follows Fedora Python packaging guidelines * Package builds and installs * Package licensing is correctly handled and recorded * No serious issues from rpmlint PACKAGE APPROVED. The Pagure repository was created at https://src.fedoraproject.org/rpms/mailman3-fedmsg-plugin-schemas Thanks for the review |