Bug 2273353 - Review Request: mailman3-fedmsg-plugin-schemas - Fedora Messaging schema for messages emitted by Mailman 3
Summary: Review Request: mailman3-fedmsg-plugin-schemas - Fedora Messaging schema for ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-04-04 11:34 UTC by Michal Konecny
Modified: 2024-04-05 12:27 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-04-05 12:27:13 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Michal Konecny 2024-04-04 11:34:37 UTC
Spec URL: https://zlopez.fedorapeople.org/mailman3-fedmsg-plugin-schemas.spec
SRPM URL: https://zlopez.fedorapeople.org/mailman3-fedmsg-plugin-schemas-1.0.0-1.el9.src.rpm
Description: A schema describing fedora-messaging messages sent by mailman.
Fedora Account System Username: zlopez

This is a new dependency for mailman3-fedmsg-plugin.

Comment 1 Neal Gompa 2024-04-05 10:59:36 UTC
Taking this review.

Comment 2 Neal Gompa 2024-04-05 11:23:58 UTC
Initial spec review:

> License:            GPL-3.0-or-later

This appears to be the wrong license. The metadata and the repository indicate LGPL-3.0-or-later.

> URL:                https://pypi.python.org/pypi/mailman3-fedmsg-plugin-schemas

This should be something that *isn't* PyPI.

Comment 3 Michal Konecny 2024-04-05 11:33:52 UTC
I updated the license to correct one (I must have just missed that) and changed the URL to GitHub repository.

Here are the updated Spec and SRPM:
Spec URL: https://zlopez.fedorapeople.org/mailman3-fedmsg-plugin-schemas.spec
SRPM URL: https://zlopez.fedorapeople.org/mailman3-fedmsg-plugin-schemas-1.0.0-1.el9.src.rpm

Comment 4 Neal Gompa 2024-04-05 11:43:21 UTC
Review notes:

* Package follows Fedora Packaging Guidelines
* Package follows Fedora Python packaging guidelines
* Package builds and installs
* Package licensing is correctly handled and recorded
* No serious issues from rpmlint

PACKAGE APPROVED.

Comment 5 Fedora Admin user for bugzilla script actions 2024-04-05 11:53:44 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/mailman3-fedmsg-plugin-schemas

Comment 6 Michal Konecny 2024-04-05 12:16:33 UTC
Thanks for the review


Note You need to log in before you can comment on or make changes to this bug.