Bug 2273619

Summary:	Review Request: rpm-spec-language-server - Language Server for RPM spec files
Product:	[Fedora] Fedora	Reporter:	Jakub Kadlčík <jkadlcik>
Component:	Package Review	Assignee:	Miroslav Suchý <msuchy>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	msuchy, package-review
Target Milestone:	---	Flags:	msuchy: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-04-16 02:25:29 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jakub Kadlčík 2024-04-05 11:03:17 UTC

Spec URL: https://download.copr.fedorainfracloud.org/results/frostyx/rpm-spec-language-server/fedora-rawhide-x86_64/07265901-rpm-spec-language-server/rpm-spec-language-server.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/frostyx/rpm-spec-language-server/fedora-rawhide-x86_64/07265901-rpm-spec-language-server/rpm-spec-language-server-0.0.1-1.fc41.src.rpm
Description:
This is a server implementing the Language Server Protocol for RPM Spec files.

Supported LSP endpoints:

- Autocompletion of macro names, spec sections and preamble keywords
- Jump to macro definition
- Expand macros on hover
- Breadcrumbs/document sections


Fedora Account System Username: frostyx

Comment 1 Miroslav Suchý 2024-04-05 14:24:54 UTC

You can consider using %autorelease and %autochangelog.

And also generating buildrequires using  https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#pyproject_buildrequires

But these are nitpicks. Otherwise, it LGTM.

Approved.

Comment 2 Fedora Admin user for bugzilla script actions 2024-04-07 09:12:40 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/rpm-spec-language-server

Comment 3 Fedora Update System 2024-04-07 09:43:14 UTC

FEDORA-2024-663d19c2b2 (rpm-spec-language-server-0.0.1-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-663d19c2b2

Comment 4 Fedora Update System 2024-04-07 09:43:14 UTC

FEDORA-2024-0dd3015622 (rpm-spec-language-server-0.0.1-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-0dd3015622

Comment 5 Fedora Update System 2024-04-08 01:07:58 UTC

FEDORA-2024-663d19c2b2 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-663d19c2b2 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-663d19c2b2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2024-04-08 01:30:40 UTC

FEDORA-2024-0dd3015622 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-0dd3015622 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-0dd3015622

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2024-04-16 02:25:29 UTC

FEDORA-2024-663d19c2b2 (rpm-spec-language-server-0.0.1-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2024-04-19 21:31:13 UTC

FEDORA-2024-0dd3015622 (rpm-spec-language-server-0.0.1-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.