Bug 2273619 - Review Request: rpm-spec-language-server - Language Server for RPM spec files
Summary: Review Request: rpm-spec-language-server - Language Server for RPM spec files
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Miroslav Suchý
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-04-05 11:03 UTC by Jakub Kadlčík
Modified: 2024-04-19 21:31 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-04-16 02:25:29 UTC
Type: ---
Embargoed:
msuchy: fedora-review+


Attachments (Terms of Use)

Description Jakub Kadlčík 2024-04-05 11:03:17 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/frostyx/rpm-spec-language-server/fedora-rawhide-x86_64/07265901-rpm-spec-language-server/rpm-spec-language-server.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/frostyx/rpm-spec-language-server/fedora-rawhide-x86_64/07265901-rpm-spec-language-server/rpm-spec-language-server-0.0.1-1.fc41.src.rpm
Description:
This is a server implementing the Language Server Protocol for RPM Spec files.

Supported LSP endpoints:

- Autocompletion of macro names, spec sections and preamble keywords
- Jump to macro definition
- Expand macros on hover
- Breadcrumbs/document sections


Fedora Account System Username: frostyx

Comment 1 Miroslav Suchý 2024-04-05 14:24:54 UTC
You can consider using %autorelease and %autochangelog.

And also generating buildrequires using  https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#pyproject_buildrequires

But these are nitpicks. Otherwise, it LGTM.

Approved.

Comment 2 Fedora Admin user for bugzilla script actions 2024-04-07 09:12:40 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rpm-spec-language-server

Comment 3 Fedora Update System 2024-04-07 09:43:14 UTC
FEDORA-2024-663d19c2b2 (rpm-spec-language-server-0.0.1-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-663d19c2b2

Comment 4 Fedora Update System 2024-04-07 09:43:14 UTC
FEDORA-2024-0dd3015622 (rpm-spec-language-server-0.0.1-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-0dd3015622

Comment 5 Fedora Update System 2024-04-08 01:07:58 UTC
FEDORA-2024-663d19c2b2 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-663d19c2b2 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-663d19c2b2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2024-04-08 01:30:40 UTC
FEDORA-2024-0dd3015622 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-0dd3015622 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-0dd3015622

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2024-04-16 02:25:29 UTC
FEDORA-2024-663d19c2b2 (rpm-spec-language-server-0.0.1-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2024-04-19 21:31:13 UTC
FEDORA-2024-0dd3015622 (rpm-spec-language-server-0.0.1-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.