Bug 2274548

Summary:	CSI_DISABLE_HOLDER_PODS config value misspelled
Product:	[Red Hat Storage] Red Hat OpenShift Data Foundation	Reporter:	Blaine Gardner <brgardne>
Component:	ocs-operator	Assignee:	Mudit Agarwal <muagarwa>
Status:	CLOSED ERRATA	QA Contact:	Oded <oviner>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	4.16	CC:	muagarwa, nberry, odf-bz-bot
Target Milestone:	---
Target Release:	ODF 4.16.0
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	4.16.0-78	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-07-17 13:19:11 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Blaine Gardner 2024-04-11 16:27:45 UTC

Description of problem (please be detailed as possible and provide log
snippests):

The configuration value that allows Multus users to disable holder pods is misspelled due to an error on my part.

Current key: CSI_REMOVE_HOLDER_PODS 
Expected key: CSI_DISABLE_HOLDER_PODS



Version of all relevant components (if applicable): 4.16



Does this issue impact your ability to continue to work with the product
(please explain in detail what is the user impact)?

This is currently a blocker for QE to qualify the feature.



Is there any workaround available to the best of your knowledge?

No.


Can this issue reproducible?

Yes



Can this issue reproduce from the UI?

Yes



Actual results:

Current config key: CSI_REMOVE_HOLDER_PODS 



Expected results:

Config key should be: CSI_DISABLE_HOLDER_PODS



Additional info: 

Fix in progress here: https://github.com/red-hat-storage/ocs-operator/pull/2551

Comment 8 Oded 2024-05-01 08:55:16 UTC

Bug fixed, the parameter name is CSI_DISABLE_HOLDER_PODS

ODF Version: odf-operator.v4.16.0-90.stable
OCP Version: 4.16.0-0.nightly-2024-04-30-053518
 
$ oc describe pods rook-ceph-operator-84b8498cd-s8mmp  | grep -i hold -C 4
    Ready:          True
    Restart Count:  1
    Environment:
      ROOK_CURRENT_NAMESPACE_ONLY:            <set to the key 'ROOK_CURRENT_NAMESPACE_ONLY' of config map 'ocs-operator-config'>  Optional: false
      CSI_DISABLE_HOLDER_PODS:                <set to the key 'CSI_DISABLE_HOLDER_PODS' of config map 'ocs-operator-config'>      Optional: false


oviner~/multus$ oc get cm ocs-operator-config -o yaml | grep -i hold -C 5
apiVersion: v1
data:
  CSI_CLUSTER_NAME: d60707ac-c2bb-4e1a-a8c9-bfc15e842608
  CSI_DISABLE_HOLDER_PODS: "true"
  CSI_ENABLE_TOPOLOGY: "false"

Comment 9 errata-xmlrpc 2024-07-17 13:19:11 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Red Hat OpenShift Data Foundation 4.16.0 security, enhancement & bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2024:4591