Bug 2274548 - CSI_DISABLE_HOLDER_PODS config value misspelled
Summary: CSI_DISABLE_HOLDER_PODS config value misspelled
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenShift Data Foundation
Classification: Red Hat Storage
Component: ocs-operator
Version: 4.16
Hardware: All
OS: All
unspecified
high
Target Milestone: ---
: ODF 4.16.0
Assignee: Mudit Agarwal
QA Contact: Oded
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-04-11 16:27 UTC by Blaine Gardner
Modified: 2024-07-17 13:19 UTC (History)
3 users (show)

Fixed In Version: 4.16.0-78
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-07-17 13:19:11 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github red-hat-storage ocs-operator pull 2551 0 None open rename CSI_REMOVE_HOLDER_PODS to CSI_DISABLE_HOLDER_PODS 2024-04-11 16:27:45 UTC
Github red-hat-storage ocs-operator pull 2560 0 None open Bug 2274548:[release-4.16] rename CSI_REMOVE_HOLDER_PODS to CSI_DISABLE_HOLDER_PODS 2024-04-16 06:23:02 UTC
Github red-hat-storage rook pull 620 0 None open BUG 2274548: [release-4.16] csi: update holder pod key 2024-04-16 06:24:19 UTC
Red Hat Product Errata RHSA-2024:4591 0 None None None 2024-07-17 13:19:14 UTC

Description Blaine Gardner 2024-04-11 16:27:45 UTC
Description of problem (please be detailed as possible and provide log
snippests):

The configuration value that allows Multus users to disable holder pods is misspelled due to an error on my part.

Current key: CSI_REMOVE_HOLDER_PODS 
Expected key: CSI_DISABLE_HOLDER_PODS



Version of all relevant components (if applicable): 4.16



Does this issue impact your ability to continue to work with the product
(please explain in detail what is the user impact)?

This is currently a blocker for QE to qualify the feature.



Is there any workaround available to the best of your knowledge?

No.


Can this issue reproducible?

Yes



Can this issue reproduce from the UI?

Yes



Actual results:

Current config key: CSI_REMOVE_HOLDER_PODS 



Expected results:

Config key should be: CSI_DISABLE_HOLDER_PODS



Additional info: 

Fix in progress here: https://github.com/red-hat-storage/ocs-operator/pull/2551

Comment 8 Oded 2024-05-01 08:55:16 UTC
Bug fixed, the parameter name is CSI_DISABLE_HOLDER_PODS

ODF Version: odf-operator.v4.16.0-90.stable
OCP Version: 4.16.0-0.nightly-2024-04-30-053518
 
$ oc describe pods rook-ceph-operator-84b8498cd-s8mmp  | grep -i hold -C 4
    Ready:          True
    Restart Count:  1
    Environment:
      ROOK_CURRENT_NAMESPACE_ONLY:            <set to the key 'ROOK_CURRENT_NAMESPACE_ONLY' of config map 'ocs-operator-config'>  Optional: false
      CSI_DISABLE_HOLDER_PODS:                <set to the key 'CSI_DISABLE_HOLDER_PODS' of config map 'ocs-operator-config'>      Optional: false


oviner~/multus$ oc get cm ocs-operator-config -o yaml | grep -i hold -C 5
apiVersion: v1
data:
  CSI_CLUSTER_NAME: d60707ac-c2bb-4e1a-a8c9-bfc15e842608
  CSI_DISABLE_HOLDER_PODS: "true"
  CSI_ENABLE_TOPOLOGY: "false"

Comment 9 errata-xmlrpc 2024-07-17 13:19:11 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Red Hat OpenShift Data Foundation 4.16.0 security, enhancement & bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2024:4591


Note You need to log in before you can comment on or make changes to this bug.