Bug 2274747
| Summary: | Review Request: tinyfiledialogs- C library for portable file dialogs | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Manish Tiwari <matiwari> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | ASSIGNED --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review?
package-review: needinfo? (panemade) |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 177841 | ||
|
Description
Manish Tiwari
2024-04-12 16:51:05 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/matiwari/tinyfiledialogs/fedora-40-x86_64/07434817-tinyfiledialogs/tinyfiledialogs.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/matiwari/tinyfiledialogs/fedora-40-x86_64/07434817-tinyfiledialogs/tinyfiledialogs-3.18.1-1.fc40.src.rpm Description: tinyfiledialogs is a cross-platform C/C++ library for displaying simple dialogs, such as file open, file save, and message boxes, in desktop applications. Fedora Account System Username: matiwari Koji Scratch Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=117522407 Updated to newest version 1) gcc command should be used with macro and not explicit list of compile flags. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_compiler_flags and https://docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/#_macros_providing_compiler_and_linker_flags 2) if package is providing header files then it should go to separate package. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages 3) when installing files, timestamp should be preserved. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_timestamps 4) License text for Zlib is not present in source archive. Ask upstream to add Zlib license text in upstream as a separate file. 5) library file libtinyfd.so should be handled properly for installation see https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages 6) don't use strip and debug_package macro This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time, but it seems that the review is still being working out by you. If this is right, please respond to this comment clearing the NEEDINFO flag and try to reach out the submitter to proceed with the review. If you're not interested in reviewing this ticket anymore, please clear the fedora-review flag and reset the assignee, so that a new reviewer can take this ticket. Without any reply, this request will shortly be resetted. |