Bug 2274747 - Review Request: tinyfiledialogs- C library for portable file dialogs
Summary: Review Request: tinyfiledialogs- C library for portable file dialogs
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-NEEDSPONSOR
TreeView+ depends on / blocked
 
Reported: 2024-04-12 16:51 UTC by Manish Tiwari
Modified: 2024-06-03 12:48 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
panemade: fedora-review?


Attachments (Terms of Use)

Description Manish Tiwari 2024-04-12 16:51:05 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/matiwari/tinyfiledialogs/fedora-40-x86_64/07297699-tinyfiledialogs/tinyfiledialogs.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/matiwari/tinyfiledialogs/fedora-40-x86_64/07297699-tinyfiledialogs/tinyfiledialogs-3.17.5-1.fc40.src.rpm

Description: tinyfiledialogs is a cross-platform C/C++ library for displaying simple dialogs, such as file open, file save, and message boxes, in desktop applications.

Fedora Account System Username: matiwari

Koji Scratch Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=116271106

Comment 1 Manish Tiwari 2024-05-10 17:48:25 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/matiwari/tinyfiledialogs/fedora-40-x86_64/07434817-tinyfiledialogs/tinyfiledialogs.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/matiwari/tinyfiledialogs/fedora-40-x86_64/07434817-tinyfiledialogs/tinyfiledialogs-3.18.1-1.fc40.src.rpm

Description: tinyfiledialogs is a cross-platform C/C++ library for displaying simple dialogs, such as file open, file save, and message boxes, in desktop applications.

Fedora Account System Username: matiwari

Koji Scratch Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=117522407

Updated to newest version

Comment 2 Parag AN(पराग) 2024-06-03 12:48:02 UTC
1) gcc command should be used with macro and not explicit list of compile flags. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_compiler_flags
and https://docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/#_macros_providing_compiler_and_linker_flags

2) if package is providing header files then it should go to separate package. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages

3) when installing files, timestamp should be preserved. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_timestamps

4) License text for Zlib is not present in source archive. Ask upstream to add Zlib license text in upstream as a separate file.

5) library file libtinyfd.so should be handled properly for installation see https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages

6) don't use strip and debug_package macro


Note You need to log in before you can comment on or make changes to this bug.