Bug 2275018

Summary:	Review Request: scx_c_schedulers - sched_ext schedulers written in c
Product:	[Fedora] Fedora	Reporter:	Jordan Rome <jordan>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	package-review
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-04-16 15:45:05 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jordan Rome 2024-04-14 21:23:25 UTC

Spec URL: https://jordalgo.fedorapeople.org/review/scx_c_schedulers/scx_c_schedulers.spec
SRPM URL: https://jordalgo.fedorapeople.org/review/scx_c_schedulers/scx_c_schedulers-0.1.8-1.fc39.src.rpm

Description:
Example sched_ext schedulers written in C (as opposed to Rust) that include:
scx_central, scx_flatcg, scx_nest, scx_pair, scx_qmap, scx_simple, scx_userland.

Fedora Account System Username: jordalgo

Comment 1 Jordan Rome 2024-04-14 21:23:28 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=116379769

Comment 2 Jordan Rome 2024-04-14 21:40:35 UTC

https://bugzilla.redhat.com/show_bug.cgi?id=2264277

Comments from this review:


Comments:
a) Is it possible to add a patch so that Cargo is not required. Probably affects:
https://github.com/sched-ext/scx/blob/main/meson.build#L23
https://github.com/sched-ext/scx/blob/main/meson.build#L110-L155

- Removed Cargo from BuildRequires


b) The spec file packaged with the rpm has LGPL-2.1 instead of LGPL-2.1-only

Rpm should now be updated with LGPL-2.1-only

c) Not directly related to this review, but might a bpf SIG be a reasonable thing to have to update all bpf packages at once so that bundling is reduced?

There exists one already apparently.

d) Should BREAKING_CHANGES.md and OVERVIEW.md also be packaged?

Added these readmes as well as INSTALL.md

e) Is it possible to run a smoke check for each binary, for example ./scx_simple -h

This is not possible without a custom kernel with sched_ext:
https://github.com/sched-ext/scx/blob/main/INSTALL.md


f) Helpful to list all the binaries, though a preference not a requirement

Where do I do this?

g) Using %exclude is not recommended, better to patch out or use sed to remove:
https://github.com/sched-ext/scx/blob/main/meson.build#L170-L174

Removed the %excludes

Comment 3 Jordan Rome 2024-04-16 15:45:05 UTC


*** This bug has been marked as a duplicate of bug 2264277 ***