Spec URL: https://jordalgo.fedorapeople.org/review/scx_c_schedulers/scx_c_schedulers.spec SRPM URL: https://jordalgo.fedorapeople.org/review/scx_c_schedulers/scx_c_schedulers-0.1.8-1.fc39.src.rpm Description: Example sched_ext schedulers written in C (as opposed to Rust) that include: scx_central, scx_flatcg, scx_nest, scx_pair, scx_qmap, scx_simple, scx_userland. Fedora Account System Username: jordalgo
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=116379769
https://bugzilla.redhat.com/show_bug.cgi?id=2264277 Comments from this review: Comments: a) Is it possible to add a patch so that Cargo is not required. Probably affects: https://github.com/sched-ext/scx/blob/main/meson.build#L23 https://github.com/sched-ext/scx/blob/main/meson.build#L110-L155 - Removed Cargo from BuildRequires b) The spec file packaged with the rpm has LGPL-2.1 instead of LGPL-2.1-only Rpm should now be updated with LGPL-2.1-only c) Not directly related to this review, but might a bpf SIG be a reasonable thing to have to update all bpf packages at once so that bundling is reduced? There exists one already apparently. d) Should BREAKING_CHANGES.md and OVERVIEW.md also be packaged? Added these readmes as well as INSTALL.md e) Is it possible to run a smoke check for each binary, for example ./scx_simple -h This is not possible without a custom kernel with sched_ext: https://github.com/sched-ext/scx/blob/main/INSTALL.md f) Helpful to list all the binaries, though a preference not a requirement Where do I do this? g) Using %exclude is not recommended, better to patch out or use sed to remove: https://github.com/sched-ext/scx/blob/main/meson.build#L170-L174 Removed the %excludes
*** This bug has been marked as a duplicate of bug 2264277 ***