Bug 2277422

Summary: Review Request: golang-github-pion-sdp3 - A Go implementation of the SDP
Product: [Fedora] Fedora Reporter: Renich Bon Ciric <renich>
Component: Package ReviewAssignee: Mikel Olasagasti Uranga <mikel>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: mikel, package-review
Target Milestone: ---Flags: mikel: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-05-07 17:35:52 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2277421    
Bug Blocks: 2277423    

Description Renich Bon Ciric 2024-04-26 20:38:07 UTC
Spec URL: https://fedorapeople.org/~renich/signaling/golang-github-pion-sdp3.spec
SRPM URL: https://fedorapeople.org/~renich/signaling/golang-github-pion-sdp3-3.0.9-1.fc39.src.rpm
Description: A Go implementation of the SDP
Fedora Account System Username: renich

Comment 1 Mikel Olasagasti Uranga 2024-04-26 20:59:06 UTC
> %global godocs          README.md LICENSES/MIT.txt

Remove LICENSES/MIT.txt

Comment 2 Mikel Olasagasti Uranga 2024-04-27 13:28:43 UTC
Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance

Thanks!

Comment 3 Fedora Admin user for bugzilla script actions 2024-05-07 17:18:04 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-pion-sdp3

Comment 4 Fedora Update System 2024-05-07 17:32:12 UTC
FEDORA-2024-aca9351352 (golang-github-pion-sdp3-3.0.9-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-aca9351352

Comment 5 Fedora Update System 2024-05-07 17:35:52 UTC
FEDORA-2024-aca9351352 (golang-github-pion-sdp3-3.0.9-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.