Bug 2277421 - Review Request: golang-github-pion-randutil - Helper library for cryptographic and mathmatical randoms
Summary: Review Request: golang-github-pion-randutil - Helper library for cryptographi...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mikel Olasagasti Uranga
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2277423 2277422
TreeView+ depends on / blocked
 
Reported: 2024-04-26 20:29 UTC by Renich Bon Ciric
Modified: 2024-05-04 03:52 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-05-04 03:44:59 UTC
Type: ---
Embargoed:
mikel: fedora-review+


Attachments (Terms of Use)

Description Renich Bon Ciric 2024-04-26 20:29:43 UTC
Spec URL: https://fedorapeople.org/~renich/signaling/golang-github-pion-randutil.spec
SRPM URL: https://fedorapeople.org/~renich/signaling/golang-github-pion-randutil-0.1.0-1.20240423gitb2a37e2.fc39.src.rpm
Description: Helper library for cryptographic and mathmatical randoms
Fedora Account System Username: renich

Comment 1 Mikel Olasagasti Uranga 2024-04-26 20:34:46 UTC
> %global godocs          README.md LICENSES/MIT.txt

Remove LICENSES/MIT.txt

> %global commit          b2a37e259481c76bdeee4909c8657eb06df36d95

Any reason to use the commit rather than 0.1.0 tag?

Comment 2 Renich Bon Ciric 2024-04-26 22:11:05 UTC
(In reply to Mikel Olasagasti Uranga from comment #1)
> > %global godocs          README.md LICENSES/MIT.txt
> 
> Remove LICENSES/MIT.txt

OK

> > %global commit          b2a37e259481c76bdeee4909c8657eb06df36d95
> 
> Any reason to use the commit rather than 0.1.0 tag?

No. Just used go2rpm without a tag. I can change it if you think it's necessary.

Comment 3 Mikel Olasagasti Uranga 2024-04-27 11:33:35 UTC
Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance

Thanks!

Comment 4 Fedora Admin user for bugzilla script actions 2024-05-04 03:24:26 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-pion-randutil

Comment 5 Fedora Update System 2024-05-04 03:41:59 UTC
FEDORA-2024-ecf450f33e (golang-github-pion-randutil-0.1.0-1.20240423gitb2a37e2.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-ecf450f33e

Comment 6 Fedora Update System 2024-05-04 03:44:59 UTC
FEDORA-2024-ecf450f33e (golang-github-pion-randutil-0.1.0-1.20240423gitb2a37e2.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.