Bug 227756

Summary:	spamassassin needs restart only if sa-update returns 0
Product:	[Fedora] Fedora	Reporter:	Milan Kerslager <milan.kerslager>
Component:	spamassassin	Assignee:	Warren Togami <wtogami>
Status:	CLOSED RAWHIDE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	6	CC:	felicity, jm, parkerm, perl-devel, reg+redhat, wtogami
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-03-16 01:17:04 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Milan Kerslager 2007-02-07 22:35:13 UTC

sa-update returns 1 if there is no update available
sa-update returns 0 if update has been succesfull

Please change /usr/share/spamassassin/sa-update.cron to not restart spamassassin
when there is no change in the updated rules.

Comment 1 Warren Togami 2007-02-07 22:43:18 UTC

Nice catch, adding this to the package...

Comment 2 Warren Togami 2007-02-07 22:47:38 UTC

Please double-check me... sa-update.cronscript now reads:
#!/bin/bash

sleep $(expr $RANDOM % 7200)
echo SpamAssassin rule update begins at `date`
# Only restart spamd if sa-update returns 0, meaning it updated the rules
/usr/bin/sa-update && /etc/init.d/spamassassin condrestart
echo

Comment 3 Milan Kerslager 2007-02-07 23:24:11 UTC

This seems to be correct.

Comment 4 Kevin Fenzi 2008-03-16 01:17:04 UTC

Can this be closed now? This looks to have been updated long ago... 

Feel free to file a new bug, or re-open if you see any further issues.