Bug 2279079
| Summary: | Review Request: libvpl-tools - Intel Video Processing Library (Intel VPL) Tools | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Simone Caronni <negativo17> | ||||||
| Component: | Package Review | Assignee: | Ali Erdinc Koroglu <aekoroglu> | ||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | aekoroglu, package-review | ||||||
| Target Milestone: | --- | Flags: | aekoroglu:
fedora-review+
aekoroglu: needinfo- |
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| URL: | https://intel.github.io/libvpl/latest/index.html | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2024-06-04 14:54:27 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Simone Caronni
2024-05-04 17:25:19 UTC
Split out of tools from libvpl 2.11.0. Copr build: https://copr.fedorainfracloud.org/coprs/build/7409007 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279079-libvpl-tools/fedora-rawhide-x86_64/07409007-libvpl-tools/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://slaanesh.fedorapeople.org/libvpl-tools.spec SRPM URL: https://slaanesh.fedorapeople.org/libvpl-tools-1.0.0-2.fc40.src.rpm Require libvpl >= 2.11.0 for building. Created attachment 2031319 [details]
The .spec file difference from Copr build 7409007 to 7409179
Copr build: https://copr.fedorainfracloud.org/coprs/build/7409179 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279079-libvpl-tools/fedora-rawhide-x86_64/07409179-libvpl-tools/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Hello Simone, I made some changes could you please apply them and try to compile in copr again ? https://aekoroglu.fedorapeople.org/libvpl-tools/spec.patch https://aekoroglu.fedorapeople.org/libvpl-tools/libvpl-tools-fedora.patch Hi Ali, I just noticed from your patch that i uploaded the source rpm for Fedora but the SPEC file I was using for CentOS 7. Here is the correct one with your patch applied: Spec URL: https://slaanesh.fedorapeople.org/libvpl-tools.spec SRPM URL: https://slaanesh.fedorapeople.org/libvpl-tools-1.0.0-3.fc40.src.rpm Thanks. Created attachment 2033946 [details]
The .spec file difference from Copr build 7409179 to 7460302
Copr build: https://copr.fedorainfracloud.org/coprs/build/7460302 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279079-libvpl-tools/fedora-rawhide-x86_64/07460302-libvpl-tools/fedora-review/review.txt Found issues: - Unversioned so-files directly in %_libdir. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Hello Simone, I found couple of this on the appstream and send a PR for that. Could you please apply spec.patch again? :) https://aekoroglu.fedorapeople.org/libvpl-tools/spec.patch https://aekoroglu.fedorapeople.org/libvpl-tools/libvpl-tools-fedora.patch https://aekoroglu.fedorapeople.org/libvpl-tools/1.patch Found couple of issues sorry :) Hi Ali, I've applied all the patches. Spec URL: https://slaanesh.fedorapeople.org/libvpl-tools.spec SRPM URL: https://slaanesh.fedorapeople.org/libvpl-tools-1.0.0-4.fc40.src.rpm Small changes compared to your patches: - libvpl-tools does not have an explicit requirement on libvpl-tools-libs, there is already a dependency on the single libraries that pulls in the package automatically. - I've renamed the patches to something more meaningful: libvpl-tools-fedora.patch -> libvpl-tools-use-system-gtest.patch 1.patch -> libvpl-tools-versioned-library.patch Please don't mix spaces with tabs. I've replaced all tabs with spaces, or the diff is inconsistent. Thanks. Hello Simone, LGTM. Thank you :) The Pagure repository was created at https://src.fedoraproject.org/rpms/libvpl-tools |