Bug 2279079 - Review Request: libvpl-tools - Intel Video Processing Library (Intel VPL) Tools
Summary: Review Request: libvpl-tools - Intel Video Processing Library (Intel VPL) Tools
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ali Erdinc Koroglu
QA Contact: Fedora Extras Quality Assurance
URL: https://intel.github.io/libvpl/latest...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-05-04 17:25 UTC by Simone Caronni
Modified: 2024-06-04 14:54 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-06-04 14:54:27 UTC
Type: ---
Embargoed:
aekoroglu: fedora-review+
aekoroglu: needinfo-


Attachments (Terms of Use)
The .spec file difference from Copr build 7409007 to 7409179 (1.80 KB, patch)
2024-05-04 19:49 UTC, Fedora Review Service
no flags Details | Diff
The .spec file difference from Copr build 7409179 to 7460302 (2.09 KB, patch)
2024-05-19 03:19 UTC, Fedora Review Service
no flags Details | Diff

Description Simone Caronni 2024-05-04 17:25:19 UTC
Spec URL: https://slaanesh.fedorapeople.org/libvpl-tools.spec
SRPM URL: https://slaanesh.fedorapeople.org/libvpl-tools-1.0.0-1.fc40.src.rpm

Description:
Intel Video Processing Library (Intel VPL) tools provide access to hardware
accelerated video decode, encode, and frame processing capabilities on Intel
GPUs from the command line.

The tools require the Intel VPL base library and a runtime library installed.
Current runtime implementations:

- Intel VPL GPU Runtime for use on Intel Iris Xe graphics and newer
- Intel Media SDK for use on legacy Intel graphics

Fedora Account System Username: slaanesh

Comment 1 Simone Caronni 2024-05-04 17:26:33 UTC
Split out of tools from libvpl 2.11.0.

Comment 2 Fedora Review Service 2024-05-04 17:27:46 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7409007
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279079-libvpl-tools/fedora-rawhide-x86_64/07409007-libvpl-tools/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Simone Caronni 2024-05-04 19:46:44 UTC
Spec URL: https://slaanesh.fedorapeople.org/libvpl-tools.spec
SRPM URL: https://slaanesh.fedorapeople.org/libvpl-tools-1.0.0-2.fc40.src.rpm

Require libvpl >= 2.11.0 for building.

Comment 4 Fedora Review Service 2024-05-04 19:49:03 UTC
Created attachment 2031319 [details]
The .spec file difference from Copr build 7409007 to 7409179

Comment 5 Fedora Review Service 2024-05-04 19:49:04 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7409179
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279079-libvpl-tools/fedora-rawhide-x86_64/07409179-libvpl-tools/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Ali Erdinc Koroglu 2024-05-17 15:16:44 UTC
Hello Simone, I made some changes could you please apply them and try to compile in copr again ?

https://aekoroglu.fedorapeople.org/libvpl-tools/spec.patch
https://aekoroglu.fedorapeople.org/libvpl-tools/libvpl-tools-fedora.patch

Comment 7 Simone Caronni 2024-05-18 17:52:33 UTC
Hi Ali, I just noticed from your patch that i uploaded the source rpm for Fedora but the SPEC file I was using for CentOS 7.

Here is the correct one with your patch applied:

Spec URL: https://slaanesh.fedorapeople.org/libvpl-tools.spec
SRPM URL: https://slaanesh.fedorapeople.org/libvpl-tools-1.0.0-3.fc40.src.rpm

Thanks.

Comment 8 Fedora Review Service 2024-05-19 03:19:17 UTC
Created attachment 2033946 [details]
The .spec file difference from Copr build 7409179 to 7460302

Comment 9 Fedora Review Service 2024-05-19 03:19:19 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7460302
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279079-libvpl-tools/fedora-rawhide-x86_64/07460302-libvpl-tools/fedora-review/review.txt

Found issues:

- Unversioned so-files directly in %_libdir.
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 10 Ali Erdinc Koroglu 2024-05-29 11:23:48 UTC
Hello Simone, I found couple of this on the appstream and send a PR for that.
Could you please apply spec.patch again? :)

https://aekoroglu.fedorapeople.org/libvpl-tools/spec.patch
https://aekoroglu.fedorapeople.org/libvpl-tools/libvpl-tools-fedora.patch
https://aekoroglu.fedorapeople.org/libvpl-tools/1.patch

Comment 11 Ali Erdinc Koroglu 2024-05-29 11:25:20 UTC
Found couple of issues sorry :)

Comment 12 Simone Caronni 2024-05-30 15:26:38 UTC
Hi Ali, I've applied all the patches.

Spec URL: https://slaanesh.fedorapeople.org/libvpl-tools.spec
SRPM URL: https://slaanesh.fedorapeople.org/libvpl-tools-1.0.0-4.fc40.src.rpm

Small changes compared to your patches:

- libvpl-tools does not have an explicit requirement on libvpl-tools-libs, there is already a dependency on the single libraries that pulls in the package automatically.
- I've renamed the patches to something more meaningful:

   libvpl-tools-fedora.patch -> libvpl-tools-use-system-gtest.patch
   1.patch -> libvpl-tools-versioned-library.patch

Comment 13 Simone Caronni 2024-05-30 15:39:29 UTC
Please don't mix spaces with tabs. I've replaced all tabs with spaces, or the diff is inconsistent. Thanks.

Comment 14 Ali Erdinc Koroglu 2024-06-03 15:52:18 UTC
Hello Simone, LGTM.
Thank you :)

Comment 15 Fedora Admin user for bugzilla script actions 2024-06-04 14:16:21 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/libvpl-tools


Note You need to log in before you can comment on or make changes to this bug.