Bug 2283586
| Summary: | Review Request: rust-cmd_lib - Common rust commandline macros and utils for shell script like tasks | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-07-06 00:11:27 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2283585 | ||
| Bug Blocks: | 2283588 | ||
|
Description
Davide Cavalca
2024-05-28 04:41:08 UTC
$ cat rust2rpm.toml [package] summary = "Common rust commandline macros and utils for shell script like tasks" [requires] test = ["procps-ng"] The package contains two files that are under a different license (WTFPL): examples/tetris.{sh,rs}.
The easiest solution would probably be to drop these two from the -devel file.
Note that the dependencies of this crate are also pretty old.
For example, structopt depends on clap v2, and has been obsolete since clap v3.
Maybe this crate can be ported to newer dependencies upstream?
env_logger 0.10 -> 0.12, byte-unit 4 -> 5, structopt -> clap 4
Spec URL: https://dcavalca.fedorapeople.org/review/rust-cmd_lib/rust-cmd_lib.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-cmd_lib/rust-cmd_lib-1.9.4-1.fc41.src.rpm Changelog: - drop examples under WTFPL $ cat rust2rpm.toml
[package]
summary = "Common rust commandline macros and utils for shell script like tasks"
[requires]
test = ["procps-ng"]
[scripts]
# Remove examples under a different license
prep.pre = ["rm examples/tetris.{sh,rs}"]
Thanks, looks good to me now! === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cmd_lib FEDORA-2024-b0efeadecb (rust-cmd_lib-1.9.4-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-b0efeadecb FEDORA-2024-b0efeadecb (rust-cmd_lib-1.9.4-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-41097de1cd (rust-cmd_lib-1.9.4-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-41097de1cd FEDORA-2024-150f5cd528 (rust-cmd_lib-1.9.4-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-150f5cd528 FEDORA-2024-150f5cd528 (rust-cmd_lib-1.9.4-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-41097de1cd (rust-cmd_lib-1.9.4-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |