Bug 2283586 - Review Request: rust-cmd_lib - Common rust commandline macros and utils for shell script like tasks
Summary: Review Request: rust-cmd_lib - Common rust commandline macros and utils for s...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2283585
Blocks: 2283588
TreeView+ depends on / blocked
 
Reported: 2024-05-28 04:41 UTC by Davide Cavalca
Modified: 2024-07-07 03:21 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-07-06 00:11:27 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2024-05-28 04:41:08 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-cmd_lib/rust-cmd_lib.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-cmd_lib/rust-cmd_lib-1.9.4-1.fc41.src.rpm

Description:
Common rust commandline macros and utils, to write shell script like
tasks easily.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2024-05-28 04:41:34 UTC
$ cat rust2rpm.toml
[package]
summary = "Common rust commandline macros and utils for shell script like tasks"

[requires]
test = ["procps-ng"]

Comment 2 Fabio Valentini 2024-07-04 16:28:46 UTC
The package contains two files that are under a different license (WTFPL): examples/tetris.{sh,rs}.
The easiest solution would probably be to drop these two from the -devel file.

Note that the dependencies of this crate are also pretty old.
For example, structopt depends on clap v2, and has been obsolete since clap v3.

Maybe this crate can be ported to newer dependencies upstream?
env_logger 0.10 -> 0.12, byte-unit 4 -> 5, structopt -> clap 4

Comment 4 Davide Cavalca 2024-07-05 15:12:02 UTC
$ cat rust2rpm.toml 
[package]
summary = "Common rust commandline macros and utils for shell script like tasks"

[requires]
test = ["procps-ng"]

[scripts]
# Remove examples under a different license
prep.pre = ["rm examples/tetris.{sh,rs}"]

Comment 5 Fabio Valentini 2024-07-05 17:47:54 UTC
Thanks, looks good to me now!

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 6 Fedora Admin user for bugzilla script actions 2024-07-05 23:59:23 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cmd_lib

Comment 7 Fedora Update System 2024-07-06 00:09:19 UTC
FEDORA-2024-b0efeadecb (rust-cmd_lib-1.9.4-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-b0efeadecb

Comment 8 Fedora Update System 2024-07-06 00:11:27 UTC
FEDORA-2024-b0efeadecb (rust-cmd_lib-1.9.4-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2024-07-06 00:22:07 UTC
FEDORA-2024-41097de1cd (rust-cmd_lib-1.9.4-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-41097de1cd

Comment 10 Fedora Update System 2024-07-06 00:45:21 UTC
FEDORA-2024-150f5cd528 (rust-cmd_lib-1.9.4-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-150f5cd528

Comment 11 Fedora Update System 2024-07-07 00:49:55 UTC
FEDORA-2024-150f5cd528 (rust-cmd_lib-1.9.4-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2024-07-07 03:21:04 UTC
FEDORA-2024-41097de1cd (rust-cmd_lib-1.9.4-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.