Bug 2283683

Please use "rust2rpm -p" to make patches for Cargo.toml.
The "extra-patches" feature is not meant to be used for this (and *if* you use it for this purpose, the result might be slightly broken).

Spec URL: https://github.com/LecrisUT/rust-metris-rpmspec/raw/83dda26784f2c9cbe603473e461adaec238ddb34/rust-sketches-ddsketch/rust-sketches-ddsketch.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-rust-metris-rpmspec-main/fedora-rawhide-x86_64/07711193-rust-sketches-ddsketch/rust-sketches-ddsketch-0.3.0-1.fc41.src.rpm

rust2rpm.toml: default

---

I have bumped the version, patching no longer needed.

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7712638
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2283683-rust-sketches-ddsketch/fedora-rawhide-x86_64/07712638-rust-sketches-ddsketch/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7712862
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2283683-rust-sketches-ddsketch/fedora-rawhide-x86_64/07712862-rust-sketches-ddsketch/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Thanks, looks good to me now!
Can you exclude the Makefile from the -devel package in some way? Either adding it to Cargo.toml as an "package.exclude" setting (possible to upstream) or adding an %exclude directive to the %files list of the "devel" subpackage (not upstreamable) would work.

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

If it's all the same, I will go with the easy option of adding:

rust2rpm.toml
```
[scripts.prep]
post = [
    "# Remove unnecessary files",
    "rm Makefile",
]
```

Thank you for the review, Fabio

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-sketches-ddsketch

FEDORA-2024-0295022f3c (rust-sketches-ddsketch-0.3.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-0295022f3c

FEDORA-2024-0295022f3c (rust-sketches-ddsketch-0.3.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2024-c29a17681c (rust-sketches-ddsketch-0.3.0-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-c29a17681c

FEDORA-2024-f1e0de0a09 (rust-sketches-ddsketch-0.3.0-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-f1e0de0a09

FEDORA-2024-f1e0de0a09 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-f1e0de0a09`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-f1e0de0a09

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-c29a17681c has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-c29a17681c`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-c29a17681c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-f1e0de0a09 (rust-sketches-ddsketch-0.3.0-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2024-c29a17681c (rust-sketches-ddsketch-0.3.0-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.