Bug 2283678 - Review Request: rust-metrics-util - Helper types/functions used by the metrics ecosystem
Summary: Review Request: rust-metrics-util - Helper types/functions used by the metric...
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/metrics-util
Whiteboard:
Depends On: 2253820 2318344 2240393 2283676 2283679 2283681 2283682 2283683
Blocks: 2283677
TreeView+ depends on / blocked
 
Reported: 2024-05-28 19:41 UTC by Cristian Le
Modified: 2024-10-29 12:51 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Cristian Le 2024-05-28 19:41:34 UTC
Spec URL: https://github.com/LecrisUT/rust-metris-rpmspec/raw/18bb026c3e9d3de4cfbc75fe92babea0b3506a81/rust-metrics-util/rust-metrics-util.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-rust-metris-rpmspec-main/fedora-rawhide-x86_64/07500435-rust-metrics-util/rust-metrics-util-0.17.0-1.fc41.src.rpm
Description: Dependency for `rust-metrics-exporter-prometheus` -> `atuin`
Fedora Account System Username: lecris

rust2rpm.toml
```toml
[requires]
build = [
    "tomcli",
]

[scripts.prep]
post = [
    "# Do not depend on criterion; it is needed only for benchmarks.",
    "tomcli set Cargo.toml del dev-dependencies.criterion",
]

[[package.extra-patches]]
comments = [
    "Relax predicates dependencies",
]
file = "rust-metrics-util-0.17.0-Relax_dependency.diff"
number = 10
```

Comment 1 Cristian Le 2024-07-05 13:43:56 UTC
Spec URL: https://github.com/LecrisUT/rust-metris-rpmspec/raw/83dda26784f2c9cbe603473e461adaec238ddb34/rust-metrics-util/rust-metrics-util.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-rust-metris-rpmspec-main/fedora-rawhide-x86_64/07711188-rust-metrics-util/rust-metrics-util-0.17.0-1.fc41.src.rpm
Description: Dependency for `rust-metrics-exporter-prometheus` -> `atuin`
Fedora Account System Username: lecris

rust2rpm.toml
```toml
[requires]
build = [
    "tomcli",
]

[scripts.prep]
post = [
    "# Do not depend on criterion; it is needed only for benchmarks.",
    "tomcli set Cargo.toml del dev-dependencies.criterion",
]

[package]
cargo-toml-patch-comments = [
    "- Relax predicates dependencies",
    "- Bump sketches-ddsketch dependency",
]
```

metrics-util-fix-metadata.diff
```
--- metrics-util-0.17.0/Cargo.toml	1970-01-01T00:00:01+00:00
+++ metrics-util-0.17.0/Cargo.toml	2024-07-05T13:11:23.410917+00:00
@@ -119,7 +119,7 @@
 default-features = false
 
 [dependencies.sketches-ddsketch]
-version = "0.2"
+version = "0.3"
 optional = true
 default-features = false
 
@@ -156,10 +156,10 @@
 version = "4.2"
 
 [dev-dependencies.predicates-core]
-version = "=1.0.5"
+version = "1.0.5"
 
 [dev-dependencies.predicates-tree]
-version = "=1.0.7"
+version = "1.0.7"
 
 [dev-dependencies.quickcheck]
 version = "1"
@@ -175,7 +175,7 @@
 version = "0.4"
 
 [dev-dependencies.sketches-ddsketch]
-version = "0.2"
+version = "0.3"
 
 [dev-dependencies.tracing]
 version = "0.1"
```

Comment 2 Fedora Review Service 2024-07-06 06:23:55 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7712641
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2283678-rust-metrics-util/fedora-rawhide-x86_64/07712641-rust-metrics-util/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fedora Review Service 2024-07-06 10:55:07 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7712864
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2283678-rust-metrics-util/fedora-rawhide-x86_64/07712864-rust-metrics-util/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Fedora Review Service 2024-08-27 15:33:34 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7947949
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2283678-rust-metrics-util/fedora-rawhide-x86_64/07947949-rust-metrics-util/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 8 Fedora Review Service 2024-10-29 12:51:12 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8186338
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2283678-rust-metrics-util/fedora-rawhide-x86_64/08186338-rust-metrics-util/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


Note You need to log in before you can comment on or make changes to this bug.