Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://github.com/LecrisUT/rust-metris-rpmspec/raw/18bb026c3e9d3de4cfbc75fe92babea0b3506a81/rust-metrics-util/rust-metrics-util.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-rust-metris-rpmspec-main/fedora-rawhide-x86_64/07500435-rust-metrics-util/rust-metrics-util-0.17.0-1.fc41.src.rpm Description: Dependency for `rust-metrics-exporter-prometheus` -> `atuin` Fedora Account System Username: lecris rust2rpm.toml ```toml [requires] build = [ "tomcli", ] [scripts.prep] post = [ "# Do not depend on criterion; it is needed only for benchmarks.", "tomcli set Cargo.toml del dev-dependencies.criterion", ] [[package.extra-patches]] comments = [ "Relax predicates dependencies", ] file = "rust-metrics-util-0.17.0-Relax_dependency.diff" number = 10 ```
Spec URL: https://github.com/LecrisUT/rust-metris-rpmspec/raw/83dda26784f2c9cbe603473e461adaec238ddb34/rust-metrics-util/rust-metrics-util.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-rust-metris-rpmspec-main/fedora-rawhide-x86_64/07711188-rust-metrics-util/rust-metrics-util-0.17.0-1.fc41.src.rpm Description: Dependency for `rust-metrics-exporter-prometheus` -> `atuin` Fedora Account System Username: lecris rust2rpm.toml ```toml [requires] build = [ "tomcli", ] [scripts.prep] post = [ "# Do not depend on criterion; it is needed only for benchmarks.", "tomcli set Cargo.toml del dev-dependencies.criterion", ] [package] cargo-toml-patch-comments = [ "- Relax predicates dependencies", "- Bump sketches-ddsketch dependency", ] ``` metrics-util-fix-metadata.diff ``` --- metrics-util-0.17.0/Cargo.toml 1970-01-01T00:00:01+00:00 +++ metrics-util-0.17.0/Cargo.toml 2024-07-05T13:11:23.410917+00:00 @@ -119,7 +119,7 @@ default-features = false [dependencies.sketches-ddsketch] -version = "0.2" +version = "0.3" optional = true default-features = false @@ -156,10 +156,10 @@ version = "4.2" [dev-dependencies.predicates-core] -version = "=1.0.5" +version = "1.0.5" [dev-dependencies.predicates-tree] -version = "=1.0.7" +version = "1.0.7" [dev-dependencies.quickcheck] version = "1" @@ -175,7 +175,7 @@ version = "0.4" [dev-dependencies.sketches-ddsketch] -version = "0.2" +version = "0.3" [dev-dependencies.tracing] version = "0.1" ```
Copr build: https://copr.fedorainfracloud.org/coprs/build/7712641 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2283678-rust-metrics-util/fedora-rawhide-x86_64/07712641-rust-metrics-util/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/7712864 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2283678-rust-metrics-util/fedora-rawhide-x86_64/07712864-rust-metrics-util/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://lecris.fedorapeople.org/reviews/rust-metrics-util/rust-metrics-util.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-metrics-util/rust-metrics-util-0.17.0-1.fc40.src.rpm Update to persistent link
Spec URL: https://lecris.fedorapeople.org/reviews/rust-metrics-util/rust-metrics-util.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-metrics-util/rust-metrics-util-0.17.0-1.fc42.src.rpm Bump dependency for ndarray 0.16
Copr build: https://copr.fedorainfracloud.org/coprs/build/7947949 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2283678-rust-metrics-util/fedora-rawhide-x86_64/07947949-rust-metrics-util/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://lecris.fedorapeople.org/reviews/rust-metrics-util/rust-metrics-util.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-metrics-util/rust-metrics-util-0.18.0-1.fc42.src.rpm Update metrics to 0.18
Copr build: https://copr.fedorainfracloud.org/coprs/build/8186338 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2283678-rust-metrics-util/fedora-rawhide-x86_64/08186338-rust-metrics-util/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Just summarizing the current status for clarity: DEBUG util.py:459: Problem 1: nothing provides requested (crate(metrics/default) >= 0.24.0 with crate(metrics/default) < 0.25.0~) DEBUG util.py:459: Problem 2: nothing provides requested (crate(mockall) >= 0.13.0 with crate(mockall) < 0.14.0~) These are bug 2253820 and bug 2318344.
I cloned https://github.com/metrics-rs/metrics, checked out the metrics-util-v0.18.0 tag, patched the dependency on mockall in the top-level Cargo.toml from "0.12" to "0.11", and ran "cargo test" in "metrics-util/". Everything still passed. Then I patched it to "0.13" (the current release) instead, and again successfully compiled and ran the tests. Therefore, you should just patch the version specification "0.12" for mockall to ">=0.11, <0.14", rather than waiting for a rust-mockall update to be coordinated with other packages that depend on it.
Since rust-metrics is your package, and it is a leaf package (so there is nothing to coordinate), you should just go ahead and update it.
(In reply to Ben Beasley from comment #10) > Then I patched it to "0.13" (the current release) > instead, and again successfully compiled and ran the tests. There is already an upstream PR for this: https://github.com/metrics-rs/metrics/pull/499
Spec URL: https://lecris.fedorapeople.org/reviews/rust-metrics-util/rust-metrics-util.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-metrics-util/rust-metrics-util-0.18.0-1.fc42.src.rpm Relaxed the mockall dependency to unblock this
Copr build: https://copr.fedorainfracloud.org/coprs/build/8403805 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2283678-rust-metrics-util/fedora-rawhide-x86_64/08403805-rust-metrics-util/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package looks good to me. Two minor points: - Version 0.19.0 is now out, you're packaging 0.18.0. Importing 0.18.0 now and updating to 0.19.0 is fine. - You're already patching Cargo.toml to relax some dependencies, at this point, using both a patch *and* tomcli to drop criterion is a bit weird, I would recommend to add the "drop criterion" bit to the patch too, and drop the tomcli dependency. I would also greatly appreciate it if you could review one of my pending packages in return. === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass 🫤 latest version of the crate is packaged 🫤 license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-metrics-util
Thank you for the review, Fabio. I'll address the minor points after `rust-metrics-exporter-prometheus` is in.
FEDORA-2025-5aa42836b1 (rust-metrics-util-0.18.0-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-5aa42836b1
FEDORA-2025-5aa42836b1 (rust-metrics-util-0.18.0-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-88b90d626c (rust-metrics-util-0.18.0-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2025-88b90d626c
FEDORA-2025-263bfa9908 (rust-metrics-util-0.18.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-263bfa9908
FEDORA-2025-e7ea7d7609 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-e7ea7d7609` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-e7ea7d7609 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-263bfa9908 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-263bfa9908` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-263bfa9908 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-88b90d626c has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-88b90d626c` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-88b90d626c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Thanks to everyone involved for tracking and moving this package review forward. Great collaboration!
This comment was flagged as spam, view the edit history to see the original text if required.