Bug 2283687

Summary:	Review Request: rust-defmac - Macro to define lambda-like macros inline
Product:	[Fedora] Fedora	Reporter:	Cristian Le <fedora>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	rust-defmac-0.2.1-12.fc41	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-07-28 21:12:06 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2283681

Description Cristian Le 2024-05-28 20:07:24 UTC

Spec URL: https://github.com/LecrisUT/rust-metris-rpmspec/raw/18bb026c3e9d3de4cfbc75fe92babea0b3506a81/rust-defmac/rust-defmac.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-rust-metris-rpmspec-main/fedora-rawhide-x86_64/07500444-rust-defmac/rust-defmac-0.2.1-1.fc41.src.rpm
Description: Dependency for `rust-ndarray` -> `rust-metrics-util` -> `rust-metrics-exporter-prometheus` -> `atuin`
Fedora Account System Username: lecris

rust2rpm.toml: default

Comment 1 Fabio Valentini 2024-07-04 21:32:17 UTC

Note: This package was previously available in Fedora. It has been retired for so long that it is no longer available in any branch of Fedora, so it is also effectively orphaned. This makes un-retirement easy, since you can just take over as new maintainer.

Please take care when re-importing the package to preserve and / or correctly override changelog.

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

(skip as appropriate for package unretirements)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 2 Cristian Le 2024-07-07 19:40:09 UTC

https://pagure.io/releng/fedora-scm-requests/issue/63474
https://pagure.io/releng/fedora-scm-requests/issue/63475

Comment 3 Cristian Le 2024-07-07 19:57:58 UTC

I've run `rpmautospec convert` but added the last commit entry manually. Hopefully the format is ok. My concern is if having 2 entries with the same version-release would be an ill-format.

Comment 4 Fabio Valentini 2024-07-11 12:05:43 UTC

> I've run `rpmautospec convert` but added the last commit entry manually. Hopefully the format is ok. My concern is if having 2 entries with the same version-release would be an ill-format.

So long as you do both in the same commit it should be fine. Commits that touch the "changelog" file don't get an automatically generated changelog entry.