Spec URL: https://github.com/LecrisUT/rust-metris-rpmspec/raw/18bb026c3e9d3de4cfbc75fe92babea0b3506a81/rust-ndarray/rust-ndarray.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-rust-metris-rpmspec-main/fedora-rawhide-x86_64/07500439-rust-ndarray/rust-ndarray-0.15.6-1.fc41.src.rpm Description: Dependency for `rust-metrics-util` -> `rust-metrics-exporter-prometheus` -> `atuin` Fedora Account System Username: lecris rust2rpm.toml ```toml [features] hide = [ "docs", ] [[package.extra-patches]] comments = [ "https://github.com/rust-ndarray/ndarray/pull/1380", "Fix approx dependency", ] file = "rust-ndarray-0.15.6-Switch_approx_dependency.diff" number = 10 ```
Spec URL: https://github.com/LecrisUT/rust-metris-rpmspec/raw/83dda26784f2c9cbe603473e461adaec238ddb34/rust-ndarray/rust-ndarray.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-rust-metris-rpmspec-main/fedora-rawhide-x86_64/07711192-rust-ndarray/rust-ndarray-0.15.6-1.fc41.src.rpm rust2rpm.toml ```toml [package] cargo-toml-patch-comments = [ "- Bump approx dependency", " https://github.com/rust-ndarray/ndarray-stats/issues/96", ] [features] hide = [ "docs", ] ``` ndarray-fix-metadata.diff ``` --- ndarray-0.15.6/Cargo.toml 1970-01-01T00:00:01+00:00 +++ ndarray-0.15.6/Cargo.toml 2024-07-05T12:45:36.759712+00:00 @@ -54,7 +54,7 @@ bench = false [dependencies.approx] -version = "0.4" +version = "0.5" optional = true default-features = false @@ -105,7 +105,7 @@ default-features = false [dev-dependencies.approx] -version = "0.4" +version = "0.5" [dev-dependencies.defmac] version = "0.2" ```
Copr build: https://copr.fedorainfracloud.org/coprs/build/7712636 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2283681-rust-ndarray/fedora-rawhide-x86_64/07712636-rust-ndarray/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/7712859 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2283681-rust-ndarray/fedora-rawhide-x86_64/07712859-rust-ndarray/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updating to enable all features and fix some other dependencies, particularly missing blas(cblas-sys). --- Spec URL: https://github.com/LecrisUT/rust-metris-rpmspec/raw/2fb7b40a6528b380d0cbf973a7f10276b2cf2ddc/rust-ndarray/rust-ndarray.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-rust-metris-rpmspec-main/fedora-rawhide-x86_64/07716590-rust-ndarray/rust-ndarray-0.15.6-1.fc41.src.rpm rust2rpm.toml ```toml [package] cargo-toml-patch-comments = [ "- Bump approx dependency", " https://github.com/rust-ndarray/ndarray/pull/1380", ] [features] enable = [ "default", "serde", "test", "rayon", "matrixmultiply-threading", ] hide = [ "blas", "cblas-sys", "docs", "serde-1", "approx-0_5", ] ``` ndarray-fix-metadata.diff ``` --- ndarray-0.15.6/Cargo.toml 1970-01-01T00:00:01+00:00 +++ ndarray-0.15.6/Cargo.toml 2024-07-05T12:45:36.759712+00:00 @@ -54,7 +54,7 @@ bench = false [dependencies.approx] -version = "0.4" +version = "0.5" optional = true default-features = false @@ -105,7 +105,7 @@ default-features = false [dev-dependencies.approx] -version = "0.4" +version = "0.5" [dev-dependencies.defmac] version = "0.2" ```
Looks like the URLs now return 404s.
Spec URL: https://lecris.fedorapeople.org/reviews/rust-ndarray/rust-ndarray.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-ndarray/rust-ndarray-0.15.6-1.fc40.src.rpm Uncommitted changes
Tried out `fbrnch` to update the links. It's the same as above otherwise though. I'll need to make FR to make the process more editable
I have not found visible issues with this review. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/ndarray-0.15.6/LICENSE-APACHE See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "MIT License", "*No copyright* Apache License (v2.0) or MIT license", "Apache License (v2.0) or MIT license". 106 files have unknown license. Detailed output of licensecheck in /home/pemensik/fedora/rawhide/2283681-rust-ndarray/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- ndarray-devel , rust-ndarray+default-devel , rust-ndarray+approx-devel , rust-ndarray+libc-devel , rust-ndarray+matrixmultiply-threading- devel , rust-ndarray+rayon-devel , rust-ndarray+rayon_-devel , rust- ndarray+serde-devel , rust-ndarray+std-devel , rust-ndarray+test-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rust-ndarray-devel-0.15.6-1.fc41.noarch.rpm rust-ndarray+default-devel-0.15.6-1.fc41.noarch.rpm rust-ndarray+approx-devel-0.15.6-1.fc41.noarch.rpm rust-ndarray+libc-devel-0.15.6-1.fc41.noarch.rpm rust-ndarray+matrixmultiply-threading-devel-0.15.6-1.fc41.noarch.rpm rust-ndarray+rayon-devel-0.15.6-1.fc41.noarch.rpm rust-ndarray+rayon_-devel-0.15.6-1.fc41.noarch.rpm rust-ndarray+serde-devel-0.15.6-1.fc41.noarch.rpm rust-ndarray+std-devel-0.15.6-1.fc41.noarch.rpm rust-ndarray+test-devel-0.15.6-1.fc41.noarch.rpm rust-ndarray-0.15.6-1.fc41.src.rpm ========================================================================== rpmlint session starts ========================================================================= rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpyhthudu8')] checks: 32, packages: 11 rust-ndarray+approx-devel.noarch: E: spelling-error ('numerics', 'Summary(en_US) numerics -> numeric, numeric s') rust-ndarray+approx-devel.noarch: E: spelling-error ('numerics', '%description -l en_US numerics -> numeric, numeric s') rust-ndarray+default-devel.noarch: E: spelling-error ('numerics', 'Summary(en_US) numerics -> numeric, numeric s') rust-ndarray+default-devel.noarch: E: spelling-error ('numerics', '%description -l en_US numerics -> numeric, numeric s') rust-ndarray+libc-devel.noarch: E: spelling-error ('numerics', 'Summary(en_US) numerics -> numeric, numeric s') rust-ndarray+libc-devel.noarch: E: spelling-error ('numerics', '%description -l en_US numerics -> numeric, numeric s') rust-ndarray+matrixmultiply-threading-devel.noarch: E: spelling-error ('numerics', 'Summary(en_US) numerics -> numeric, numeric s') rust-ndarray+matrixmultiply-threading-devel.noarch: E: spelling-error ('numerics', '%description -l en_US numerics -> numeric, numeric s') rust-ndarray+rayon-devel.noarch: E: spelling-error ('numerics', 'Summary(en_US) numerics -> numeric, numeric s') rust-ndarray+rayon-devel.noarch: E: spelling-error ('numerics', '%description -l en_US numerics -> numeric, numeric s') rust-ndarray+rayon_-devel.noarch: E: spelling-error ('numerics', 'Summary(en_US) numerics -> numeric, numeric s') rust-ndarray+rayon_-devel.noarch: E: spelling-error ('numerics', '%description -l en_US numerics -> numeric, numeric s') rust-ndarray+serde-devel.noarch: E: spelling-error ('numerics', 'Summary(en_US) numerics -> numeric, numeric s') rust-ndarray+serde-devel.noarch: E: spelling-error ('numerics', '%description -l en_US numerics -> numeric, numeric s') rust-ndarray+std-devel.noarch: E: spelling-error ('numerics', 'Summary(en_US) numerics -> numeric, numeric s') rust-ndarray+std-devel.noarch: E: spelling-error ('numerics', '%description -l en_US numerics -> numeric, numeric s') rust-ndarray+test-devel.noarch: E: spelling-error ('numerics', 'Summary(en_US) numerics -> numeric, numeric s') rust-ndarray+test-devel.noarch: E: spelling-error ('numerics', '%description -l en_US numerics -> numeric, numeric s') rust-ndarray.src: E: spelling-error ('numerics', 'Summary(en_US) numerics -> numeric, numeric s') rust-ndarray.src: E: spelling-error ('numerics', '%description -l en_US numerics -> numeric, numeric s') rust-ndarray-devel.noarch: E: spelling-error ('numerics', 'Summary(en_US) numerics -> numeric, numeric s') rust-ndarray-devel.noarch: E: spelling-error ('numerics', '%description -l en_US numerics -> numeric, numeric s') rust-ndarray+approx-devel.noarch: W: no-documentation rust-ndarray+default-devel.noarch: W: no-documentation rust-ndarray+libc-devel.noarch: W: no-documentation rust-ndarray+matrixmultiply-threading-devel.noarch: W: no-documentation rust-ndarray+rayon-devel.noarch: W: no-documentation rust-ndarray+rayon_-devel.noarch: W: no-documentation rust-ndarray+serde-devel.noarch: W: no-documentation rust-ndarray+std-devel.noarch: W: no-documentation rust-ndarray+test-devel.noarch: W: no-documentation =================================== 11 packages and 0 specfiles checked; 22 errors, 9 warnings, 53 filtered, 22 badness; has taken 1.8 s ================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 10 rust-ndarray+approx-devel.noarch: E: spelling-error ('numerics', 'Summary(en_US) numerics -> numeric, numeric s') rust-ndarray+approx-devel.noarch: E: spelling-error ('numerics', '%description -l en_US numerics -> numeric, numeric s') rust-ndarray+std-devel.noarch: E: spelling-error ('numerics', 'Summary(en_US) numerics -> numeric, numeric s') rust-ndarray+std-devel.noarch: E: spelling-error ('numerics', '%description -l en_US numerics -> numeric, numeric s') rust-ndarray-devel.noarch: E: spelling-error ('numerics', 'Summary(en_US) numerics -> numeric, numeric s') rust-ndarray-devel.noarch: E: spelling-error ('numerics', '%description -l en_US numerics -> numeric, numeric s') rust-ndarray+rayon_-devel.noarch: E: spelling-error ('numerics', 'Summary(en_US) numerics -> numeric, numeric s') rust-ndarray+rayon_-devel.noarch: E: spelling-error ('numerics', '%description -l en_US numerics -> numeric, numeric s') rust-ndarray+libc-devel.noarch: E: spelling-error ('numerics', 'Summary(en_US) numerics -> numeric, numeric s') rust-ndarray+libc-devel.noarch: E: spelling-error ('numerics', '%description -l en_US numerics -> numeric, numeric s') rust-ndarray+rayon-devel.noarch: E: spelling-error ('numerics', 'Summary(en_US) numerics -> numeric, numeric s') rust-ndarray+rayon-devel.noarch: E: spelling-error ('numerics', '%description -l en_US numerics -> numeric, numeric s') rust-ndarray+default-devel.noarch: E: spelling-error ('numerics', 'Summary(en_US) numerics -> numeric, numeric s') rust-ndarray+default-devel.noarch: E: spelling-error ('numerics', '%description -l en_US numerics -> numeric, numeric s') rust-ndarray+serde-devel.noarch: E: spelling-error ('numerics', 'Summary(en_US) numerics -> numeric, numeric s') rust-ndarray+serde-devel.noarch: E: spelling-error ('numerics', '%description -l en_US numerics -> numeric, numeric s') rust-ndarray+test-devel.noarch: E: spelling-error ('numerics', 'Summary(en_US) numerics -> numeric, numeric s') rust-ndarray+test-devel.noarch: E: spelling-error ('numerics', '%description -l en_US numerics -> numeric, numeric s') rust-ndarray+matrixmultiply-threading-devel.noarch: E: spelling-error ('numerics', 'Summary(en_US) numerics -> numeric, numeric s') rust-ndarray+matrixmultiply-threading-devel.noarch: E: spelling-error ('numerics', '%description -l en_US numerics -> numeric, numeric s') rust-ndarray+approx-devel.noarch: W: no-documentation rust-ndarray+std-devel.noarch: W: no-documentation rust-ndarray+rayon_-devel.noarch: W: no-documentation rust-ndarray+libc-devel.noarch: W: no-documentation rust-ndarray+rayon-devel.noarch: W: no-documentation rust-ndarray+default-devel.noarch: W: no-documentation rust-ndarray+serde-devel.noarch: W: no-documentation rust-ndarray+test-devel.noarch: W: no-documentation rust-ndarray+matrixmultiply-threading-devel.noarch: W: no-documentation 10 packages and 0 specfiles checked; 20 errors, 9 warnings, 48 filtered, 20 badness; has taken 1.2 s Source checksums ---------------- https://crates.io/api/v1/crates/ndarray/0.15.6/download#/ndarray-0.15.6.crate : CHECKSUM(SHA256) this package : adb12d4e967ec485a5f71c6311fe28158e9d6f4bc4a447b474184d0f91a8fa32 CHECKSUM(SHA256) upstream package : adb12d4e967ec485a5f71c6311fe28158e9d6f4bc4a447b474184d0f91a8fa32 Requires -------- rust-ndarray-devel (rpmlib, GLIBC filtered): (crate(matrixmultiply) >= 0.3.2 with crate(matrixmultiply) < 0.4.0~) (crate(matrixmultiply/cgemm) >= 0.3.2 with crate(matrixmultiply/cgemm) < 0.4.0~) (crate(num-complex) >= 0.4.0 with crate(num-complex) < 0.5.0~) (crate(num-integer) >= 0.1.39 with crate(num-integer) < 0.2.0~) (crate(num-traits) >= 0.2.0 with crate(num-traits) < 0.3.0~) (crate(rawpointer/default) >= 0.2.0 with crate(rawpointer/default) < 0.3.0~) /usr/bin/sh cargo rust rust-ndarray+default-devel (rpmlib, GLIBC filtered): cargo crate(ndarray) crate(ndarray/std) rust-ndarray+approx-devel (rpmlib, GLIBC filtered): (crate(approx) >= 0.5.0 with crate(approx) < 0.6.0~) cargo crate(ndarray) rust-ndarray+libc-devel (rpmlib, GLIBC filtered): (crate(libc/default) >= 0.2.82 with crate(libc/default) < 0.3.0~) cargo crate(ndarray) rust-ndarray+matrixmultiply-threading-devel (rpmlib, GLIBC filtered): (crate(matrixmultiply/threading) >= 0.3.2 with crate(matrixmultiply/threading) < 0.4.0~) cargo crate(ndarray) rust-ndarray+rayon-devel (rpmlib, GLIBC filtered): cargo crate(ndarray) crate(ndarray/rayon_) crate(ndarray/std) rust-ndarray+rayon_-devel (rpmlib, GLIBC filtered): (crate(rayon/default) >= 1.0.3 with crate(rayon/default) < 2.0.0~) cargo crate(ndarray) rust-ndarray+serde-devel (rpmlib, GLIBC filtered): (crate(serde) >= 1.0.0 with crate(serde) < 2.0.0~) (crate(serde/alloc) >= 1.0.0 with crate(serde/alloc) < 2.0.0~) cargo crate(ndarray) rust-ndarray+std-devel (rpmlib, GLIBC filtered): (crate(matrixmultiply/std) >= 0.3.2 with crate(matrixmultiply/std) < 0.4.0~) (crate(num-traits/std) >= 0.2.0 with crate(num-traits/std) < 0.3.0~) cargo crate(ndarray) rust-ndarray+test-devel (rpmlib, GLIBC filtered): cargo crate(ndarray) Provides -------- rust-ndarray-devel: crate(ndarray) rust-ndarray-devel rust-ndarray+default-devel: crate(ndarray/default) rust-ndarray+default-devel rust-ndarray+approx-devel: crate(ndarray/approx) rust-ndarray+approx-devel rust-ndarray+libc-devel: crate(ndarray/libc) rust-ndarray+libc-devel rust-ndarray+matrixmultiply-threading-devel: crate(ndarray/matrixmultiply-threading) rust-ndarray+matrixmultiply-threading-devel rust-ndarray+rayon-devel: crate(ndarray/rayon) rust-ndarray+rayon-devel rust-ndarray+rayon_-devel: crate(ndarray/rayon_) rust-ndarray+rayon_-devel rust-ndarray+serde-devel: crate(ndarray/serde) rust-ndarray+serde-devel rust-ndarray+std-devel: crate(ndarray/std) rust-ndarray+std-devel rust-ndarray+test-devel: crate(ndarray/test) rust-ndarray+test-devel Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2283681 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Python, R, C/C++, fonts, Ocaml, SugarActivity, Haskell, PHP, Java, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH But not rust expert, not giving ack right away.
One important check to do for rust packages is to check installability. Some unmet dependencies may be hidden there enabling all features usually takes care of that at the cost of build/test time, but `mock --postinstall` is also a good catch for those most of the time. About the duplicate file listed, I remember seeing something similar and we ended up as something that should be handled in rust2rpm [1] [1]: https://bugzilla.redhat.com/show_bug.cgi?id=2279515#c3
> About the duplicate file listed, I remember seeing something similar and we ended up as something that should be handled in rust2rpm [1] To clarify: No, this is a harmless warning from RPM. You can ignore it. The way the %files are listed is correct and will not lead to duplicates or other issues.
Two issues I see so far: 1. The latest version is 0.16.1, you're packaging 0.15.6. Is this intentional? 2. The Cargo.toml patch looks wrong. This crate supports both approx 0.4 and 0.5, bumping the un-versioned dependency from 0.4 to 0.5 just makes both features identical. ``` [dependencies.approx] version = "0.4" optional = true default-features = false [dependencies.approx-0_5] version = "0.5" optional = true default-features = false package = "approx" ``` I would recommend to remove the "approx" *and* "approx-0_5" features (and the "docs" feature that depends on these) instead, and bump only the remaining dev-dependency from 0.4 to 0.5. That is, unless what you're working on explicitly depends on either the ndarray/approx or ndarray/approx-0_5 features.
> The latest version is 0.16.1, you're packaging 0.15.6. Is this intentional? The reason was that `0.16` was not available at that time :D. I will bump it and fix metrics-util. > 2. The Cargo.toml patch looks wrong. This crate supports both approx 0.4 and 0.5, bumping the un-versioned dependency from 0.4 to 0.5 just makes both features identical. I only needed the `approx-0_5` and I saw that at the time the main branch simply removed `approx-0_5` and bumped it, so I was considering to patch the appropriate dependents. But this has resolved itself with the new release. I will update the reviews shortly.
Spec URL: https://lecris.fedorapeople.org/reviews/rust-ndarray/rust-ndarray.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-ndarray/rust-ndarray-0.16.1-1.fc40.src.rpm Bumped ndarray packaged version
Copr build: https://copr.fedorainfracloud.org/coprs/build/7947945 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2283681-rust-ndarray/fedora-rawhide-x86_64/07947945-rust-ndarray/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Sorry for the loooong delay here 😬 It looks like I somehow (not sure how) missed the fact that you posted an update. Package looks pretty good to me. I also ran a scratch build on rawhide to confirm that the package builds + tests pass on all architectures (they do 🥳). My only non-blocking RFE would be to exclude some files that are not useful in the package: - misc/: SVG images - scripts/: only useful for upstream development - clippy.toml: only useful for upstream development - rustfmt.toml: only useful for upstream development In particular, the scripts in scripts/ are executable bash scripts, and they cause the dependency generator to include /bin/bash and /bin/sh as dependencies of the -devel subpackage. Dropping the scripts/ folder should avoid this. === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass (some dropped with justification) ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version (*NOT* pre-release) filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-ndarray
Thank you for the review, Fabio. I'll handle the exclusions when importing
FEDORA-2024-55497e2eee (rust-ndarray-0.16.1-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-55497e2eee
FEDORA-2024-55497e2eee (rust-ndarray-0.16.1-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-69e8621eb8 (rust-ndarray-0.16.1-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-69e8621eb8
FEDORA-2024-31fef07e10 (rust-ndarray-0.16.1-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-31fef07e10
FEDORA-2024-d50e30bc43 (rust-ndarray-0.16.1-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-d50e30bc43
FEDORA-2024-69e8621eb8 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-69e8621eb8` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-69e8621eb8 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-31fef07e10 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-31fef07e10` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-31fef07e10 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-d50e30bc43 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-d50e30bc43` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-d50e30bc43 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-d50e30bc43 (rust-ndarray-0.16.1-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-69e8621eb8 (rust-ndarray-0.16.1-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-31fef07e10 (rust-ndarray-0.16.1-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.