Bug 2284049

Summary: Review Request: rust-struct-field-names-as-array - For generating the field names of named structs as constants
Product: [Fedora] Fedora Reporter: Davide Cavalca <davide>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: decathorpe: fedora-review+
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/struct-field-names-as-array
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-07-13 15:57:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2284048    
Bug Blocks: 2290480    

Description Davide Cavalca 2024-05-30 23:35:54 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-struct-field-names-as-array/rust-struct-field-names-as-array.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-struct-field-names-as-array/rust-struct-field-names-as-array-derive-0.3.0-1.fc41.src.rpm

Description:
Crate for generating the field names of named structs as constants.

Fedora Account System Username: dcavalca

Comment 1 Fabio Valentini 2024-07-09 14:52:53 UTC
Looks like you linked the wrong SRPM file.

Comment 3 Fedora Review Service 2024-07-12 04:43:56 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7726979
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2284049-rust-struct-field-names-as-array/fedora-rawhide-x86_64/07726979-rust-struct-field-names-as-array/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Fabio Valentini 2024-07-13 15:33:44 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 5 Fedora Admin user for bugzilla script actions 2024-07-13 15:42:32 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-struct-field-names-as-array

Comment 6 Fedora Update System 2024-07-13 15:52:40 UTC
FEDORA-2024-5094f10967 (rust-struct-field-names-as-array-0.3.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-5094f10967

Comment 7 Fedora Update System 2024-07-13 15:57:26 UTC
FEDORA-2024-5094f10967 (rust-struct-field-names-as-array-0.3.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2024-07-13 16:01:53 UTC
FEDORA-2024-9d0afe2606 (rust-struct-field-names-as-array-0.3.0-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-9d0afe2606

Comment 9 Fedora Update System 2024-07-13 16:18:10 UTC
FEDORA-2024-1d059bea89 (rust-struct-field-names-as-array-0.3.0-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-1d059bea89

Comment 10 Fedora Update System 2024-07-14 02:23:12 UTC
FEDORA-2024-9d0afe2606 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-9d0afe2606 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-9d0afe2606

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2024-07-14 04:30:00 UTC
FEDORA-2024-1d059bea89 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-1d059bea89 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-1d059bea89

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2024-07-22 01:24:23 UTC
FEDORA-2024-9d0afe2606 (rust-struct-field-names-as-array-0.3.0-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2024-07-22 01:48:32 UTC
FEDORA-2024-1d059bea89 (rust-struct-field-names-as-array-0.3.0-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.