Bug 2290480 - Review Request: rust-monitord - Know how happy your systemd is
Summary: Review Request: rust-monitord - Know how happy your systemd is
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/monitord
Whiteboard:
Depends On: 2284044 2284047 2284049
Blocks: 2290730
TreeView+ depends on / blocked
 
Reported: 2024-06-04 22:00 UTC by Davide Cavalca
Modified: 2024-08-02 05:50 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-07-17 22:36:30 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 7530279 to 7543772 (1.12 KB, patch)
2024-06-06 15:35 UTC, Fedora Review Service
no flags Details | Diff

Description Davide Cavalca 2024-06-04 22:00:51 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-monitord/rust-monitord.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-monitord/rust-monitord-0.8.3-1.fc41.src.rpm

Description:
monitord is a library and daemon to gather statistics about systemd.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2024-06-04 22:02:38 UTC
$ cat rust2rpm.toml 
[package]
summary = "Know how happy your systemd is"
description = "monitord is a library and daemon to gather statistics about systemd."
cargo-toml-patch-comments = [
  "bump int_enum to 1.1",
  "bump struct-field-names-as-array to 0.3",
]
extra-patches = [
  { number = 2, file = "monitord-struct-field-names-as-array-0.3.patch", comments = ["https://github.com/cooperlees/monitord/commit/37d0c20c70512bead7f840c39f7c004a1582d12f"] },
  { number = 3, file = "monitord-int-enum-1.1.patch", comments = ["https://github.com/cooperlees/monitord/commit/391398a95e12caffa745bdd2acab3c111d2477cc"] },
]
extra-files = [
  "%config(noreplace) %{_sysconfdir}/monitord.conf",
]

[scripts]
prep.pre = [
  # Drop prebuilt docs
  "rm -r docs",
]
install.post = [
  "install -Dpm0644 -t %{buildroot}%{_sysconfdir} monitord.conf",
]

Comment 2 Fedora Review Service 2024-06-04 22:03:18 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7530279
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2290480-rust-monitord/fedora-rawhide-x86_64/07530279-rust-monitord/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Davide Cavalca 2024-06-06 15:20:36 UTC
$ cat rust2rpm.toml 
[package]
summary = "Know how happy your systemd is"
description = "monitord is a library and daemon to gather statistics about systemd."
extra-files = [
  "%config(noreplace) %{_sysconfdir}/monitord.conf",
]

[scripts]
prep.pre = [
  # Drop prebuilt docs
  "rm -r docs",
]
install.post = [
  "install -Dpm0644 -t %{buildroot}%{_sysconfdir} monitord.conf",
]

Comment 5 Fedora Review Service 2024-06-06 15:35:24 UTC
Created attachment 2036570 [details]
The .spec file difference from Copr build 7530279 to 7543772

Comment 6 Fedora Review Service 2024-06-06 15:35:26 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7543772
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2290480-rust-monitord/fedora-rawhide-x86_64/07543772-rust-monitord/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Michel Lind 2024-07-11 20:33:19 UTC
[fedora-review-service-build]

Comment 8 Michel Lind 2024-07-11 22:19:48 UTC
Did you forget to package rust-struct-field-names-as-array?

rust-struct-field-names-as-array-derive exists but not the crate that's using it

Problem: nothing provides requested (crate(struct-field-names-as-array/default) >= 0.3.0 with crate(struct-field-names-as-array/default) < 0.4.0~)

Comment 9 Davide Cavalca 2024-07-13 15:53:38 UTC
rust-struct-field-names-as-array should be in Rawhide now.

Comment 10 Michel Lind 2024-07-15 22:39:05 UTC
Waiting for upstream to clarify a license discrepancy - Cargo.toml says GPL-2.0-or-later but LICENSE file is for LGPL 2.1(+)

Comment 11 Davide Cavalca 2024-07-17 21:10:24 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-monitord/rust-monitord.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-monitord/rust-monitord-0.8.3-1.fc41.src.rpm

Changelog:
- backport upstream commit to fix the license

Comment 12 Davide Cavalca 2024-07-17 21:10:34 UTC
$ cat rust2rpm.toml 
[package]
summary = "Know how happy your systemd is"
description = "monitord is a library and daemon to gather statistics about systemd."
extra-files = [
  "%config(noreplace) %{_sysconfdir}/monitord.conf",
]
extra-patches = [
  { "number" = 2, "file" = "https://github.com/cooperlees/monitord/commit/8ced4d5c5fe507cd583e6518d88ae6e2b5a45cec.patch", "comments" = ["Switch license file from LGPL 2.1 to GPL 2"] },
]

[scripts]
prep.pre = [
  # Drop prebuilt docs
  "rm -r docs",
]
install.post = [
  "install -Dpm0644 -t %{buildroot}%{_sysconfdir} monitord.conf",
]

Comment 13 Michel Lind 2024-07-17 21:27:31 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (GPL-2.0-only) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard rust-$crate` to automate):

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 14 Fedora Admin user for bugzilla script actions 2024-07-17 21:40:54 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-monitord

Comment 15 Fedora Update System 2024-07-17 22:32:21 UTC
FEDORA-2024-7d7e7af423 (rust-monitord-0.8.3-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-7d7e7af423

Comment 16 Fedora Update System 2024-07-17 22:36:30 UTC
FEDORA-2024-7d7e7af423 (rust-monitord-0.8.3-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 17 Fedora Update System 2024-07-24 00:21:25 UTC
FEDORA-2024-e117ad28ae (rust-monitord-0.8.4-1.fc40 and rust-monitord-exporter-0.3.0-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-e117ad28ae

Comment 18 Fedora Update System 2024-07-24 00:56:23 UTC
FEDORA-2024-fd9e2e77f1 (rust-monitord-0.8.4-1.fc39 and rust-monitord-exporter-0.3.0-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-fd9e2e77f1

Comment 19 Fedora Update System 2024-07-25 01:52:44 UTC
FEDORA-2024-e117ad28ae has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-e117ad28ae \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-e117ad28ae

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 20 Fedora Update System 2024-07-25 02:41:16 UTC
FEDORA-2024-fd9e2e77f1 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-fd9e2e77f1 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-fd9e2e77f1

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 21 Fedora Update System 2024-08-02 03:49:09 UTC
FEDORA-2024-fd9e2e77f1 (rust-monitord-0.8.4-1.fc39 and rust-monitord-exporter-0.3.0-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 22 Fedora Update System 2024-08-02 05:50:54 UTC
FEDORA-2024-e117ad28ae (rust-monitord-0.8.4-1.fc40 and rust-monitord-exporter-0.3.0-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.