Bug 2284089

Summary: ImageMagick json output adds extra comma with 7.1.1-26
Product: [Fedora] Fedora Reporter: Mamoru TASAKA <mtasaka>
Component: ImageMagickAssignee: Luya Tshimbalanga <luya_tfz>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: blaise, davide, epel-packagers-sig, extras-qa, fedora, luya_tfz, michel, ngompa13, pampelmuse, pvalena, releng, sergio
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ImageMagick-7.1.1.33-1.fc40 ImageMagick-7.1.1.33-1.fc39 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 2261661 Environment:
Last Closed: 2024-06-24 06:37:09 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2259429    
Bug Blocks: 2261661    

Description Mamoru TASAKA 2024-05-31 05:59:09 UTC
+++ This bug was initially created as a clone of Bug #2261661 +++

rubygem-mini_magick failed to build from source in Fedora rawhide/f40

https://koji.fedoraproject.org/koji/taskinfo?taskID=112411922


For details on the mass rebuild see:

https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild
Please fix rubygem-mini_magick at your earliest convenience and set the bug's status to
ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks,
rubygem-mini_magick will be orphaned. Before branching of Fedora 41,
rubygem-mini_magick will be retired, if it still fails to build.

For more details on the FTBFS policy, please visit:
https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/

--- Additional comment from Fedora Release Engineering on 2024-01-30 07:11:06 JST ---



--- Additional comment from Fedora Release Engineering on 2024-01-30 07:11:11 JST ---

file root.log too big, will only attach last 32768 bytes

--- Additional comment from Fedora Release Engineering on 2024-01-30 07:11:14 JST ---

Comment 1 Mamoru TASAKA 2024-05-31 06:07:25 UTC
```
Failures:
  1) With ImageMagick MiniMagick::Image#[] reads exif
     Failure/Error: expect(subject["EXIF:Flash"]).to eq "0"
       expected: "0"
            got: "0, "
```

This test is okay with ImageMagick 7.1.1-15, broken with -26, starting with this commit:
https://github.com/ImageMagick/ImageMagick/commit/bca743becfa97355f3905eab6e68ecc8b91300d9 

Small reproducer is, when you try `$ convert exif.jpg "json:" | grep  exif:Flash`,

* with the previous commit https://github.com/ImageMagick/ImageMagick/commit/20fbdeaa82bc6b67ddebe85a46650b3906b77031 
  output was something like:
```
      "exif:Flash": "0",
      "exif:FlashPixVersion": "0100",
```

* with https://github.com/ImageMagick/ImageMagick/commit/bca743becfa97355f3905eab6e68ecc8b91300d9 
```
      "exif:Flash": "0, ",
      "exif:FlashPixVersion": "0100",
```

You can see extra comma to the output, even with 7.1.1-26.

After some additional refactoring and etc, the above issue is fixed with
https://github.com/ImageMagick/ImageMagick/commit/c4b3e141a764ff1f638aa5ac19033dc573451978 

The above commit is included in -28.

Comment 2 Fedora Update System 2024-06-18 21:38:51 UTC
FEDORA-2024-6d8a3f52a5 (ImageMagick-7.1.1.33-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-6d8a3f52a5

Comment 3 Fedora Update System 2024-06-18 21:39:40 UTC
FEDORA-2024-93ffff4464 (ImageMagick-7.1.1.33-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-93ffff4464

Comment 4 Fedora Update System 2024-06-19 01:46:04 UTC
FEDORA-2024-93ffff4464 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-93ffff4464`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-93ffff4464

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 5 Fedora Update System 2024-06-19 02:05:55 UTC
FEDORA-2024-6d8a3f52a5 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-6d8a3f52a5`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-6d8a3f52a5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2024-06-24 06:37:09 UTC
FEDORA-2024-6d8a3f52a5 (ImageMagick-7.1.1.33-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2024-06-27 01:42:53 UTC
FEDORA-2024-93ffff4464 (ImageMagick-7.1.1.33-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.