Bug 2292543
| Summary: | Review Request: rust-dlopen2_derive - Derive macros for the dlopen2 crate | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jonathan Steffan <jonathansteffan> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | decathorpe:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/dlopen2_derive | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-07-13 18:33:43 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2292542 | ||
|
Description
Jonathan Steffan
2024-06-15 23:05:59 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7617807 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2292543-rust-dlopen2_derive/fedora-rawhide-x86_64/07617807-rust-dlopen2_derive/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. The error that is printed by rust2rpm if you don't use "--ignore-missing-license-file" isn't there for fun.
> # FIXME: no license files detected
This needs to be addressed in some way.
The MIT license is one of the licenses that requires redistributed sources to contain a copy of the license text.
Please file a ticket with the upstream project about including the license text in published crates.
https://github.com/OpenByteDev/dlopen2/issues/12 has been filed for both of the dlopen2 crates. Thanks! You can temporarily include the license texts from https://github.com/OpenByteDev/dlopen2 manually until upstream publishes new versions with the license texts included. Here's a package where I had to do this recently that can serve as an example of how to do it: https://src.fedoraproject.org/rpms/rust-zune-jpeg/blob/rawhide/f/rust-zune-jpeg.spec#_15 Spec URL: https://jsteffan.fedorapeople.org/envision/rust-dlopen2_derive.spec SRPM URL: https://jsteffan.fedorapeople.org/envision/rust-dlopen2_derive-0.4.0-1.fc39/rust-dlopen2_derive-0.4.0-1.fc40.src.rpm Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files (manually included from upstream) ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-dlopen2_derive FEDORA-2024-dc0b277171 (rust-dlopen2_derive-0.4.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-dc0b277171 FEDORA-2024-dc0b277171 (rust-dlopen2_derive-0.4.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. |