Bug 2292543 - Review Request: rust-dlopen2_derive - Derive macros for the dlopen2 crate
Summary: Review Request: rust-dlopen2_derive - Derive macros for the dlopen2 crate
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/dlopen2_derive
Whiteboard:
Depends On:
Blocks: 2292542
TreeView+ depends on / blocked
 
Reported: 2024-06-15 23:05 UTC by Jonathan Steffan
Modified: 2024-07-13 18:33 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-07-13 18:33:43 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Jonathan Steffan 2024-06-15 23:05:59 UTC
Spec URL: https://jsteffan.fedorapeople.org/envision/rust-dlopen2_derive.spec
SRPM URL: https://jsteffan.fedorapeople.org/envision/rust-dlopen2_derive-0.4.0-1.fc39/rust-dlopen2_derive-0.4.0-1.fc40.src.rpm
Description: Derive macros for the dlopen2 crate.
Fedora Account System Username: jsteffan

Comment 1 Fedora Review Service 2024-06-15 23:12:19 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7617807
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2292543-rust-dlopen2_derive/fedora-rawhide-x86_64/07617807-rust-dlopen2_derive/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-07-05 14:21:57 UTC
The error that is printed by rust2rpm if you don't use "--ignore-missing-license-file" isn't there for fun.

> # FIXME: no license files detected

This needs to be addressed in some way.

The MIT license is one of the licenses that requires redistributed sources to contain a copy of the license text.
Please file a ticket with the upstream project about including the license text in published crates.

Comment 3 Jonathan Steffan 2024-07-08 16:47:15 UTC
https://github.com/OpenByteDev/dlopen2/issues/12 has been filed for both of the dlopen2 crates.

Comment 4 Fabio Valentini 2024-07-11 11:41:20 UTC
Thanks!

You can temporarily include the license texts from https://github.com/OpenByteDev/dlopen2 manually until upstream publishes new versions with the license texts included.

Here's a package where I had to do this recently that can serve as an example of how to do it:
https://src.fedoraproject.org/rpms/rust-zune-jpeg/blob/rawhide/f/rust-zune-jpeg.spec#_15

Comment 6 Fabio Valentini 2024-07-13 15:07:24 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files (manually included from upstream)
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 7 Fedora Admin user for bugzilla script actions 2024-07-13 17:06:27 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-dlopen2_derive

Comment 8 Fedora Update System 2024-07-13 17:16:51 UTC
FEDORA-2024-dc0b277171 (rust-dlopen2_derive-0.4.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-dc0b277171

Comment 9 Fedora Update System 2024-07-13 18:33:43 UTC
FEDORA-2024-dc0b277171 (rust-dlopen2_derive-0.4.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.