Bug 2292551

Summary: Review Request: rust-tracker-macros - Macros for the tracker crate
Product: [Fedora] Fedora Reporter: Jonathan Steffan <jonathansteffan>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: decathorpe: fedora-review+
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/tracker-macros
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-07-14 17:00:27 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2292552    

Description Jonathan Steffan 2024-06-15 23:19:02 UTC
Spec URL: https://jsteffan.fedorapeople.org/envision/rust-tracker-macros.spec
SRPM URL: https://jsteffan.fedorapeople.org/envision/rust-tracker-macros-0.2.1-1.fc39/rust-tracker-macros-0.2.1-1.fc40.src.rpm
Description: Macros for the tracker crate
Fedora Account System Username: jsteffan

Comment 1 Fedora Review Service 2024-06-15 23:25:25 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7617823
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2292551-rust-tracker-macros/fedora-rawhide-x86_64/07617823-rust-tracker-macros/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-07-13 18:26:47 UTC
> # FIXME: no license files detected

There are license files upstream:
https://github.com/AaronErhardt/Tracker

You can temporarily include those files until upstream adds them to published crates.

Comment 4 Fabio Valentini 2024-07-14 10:08:15 UTC
Thank you, looks good to me!

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
🫤 license files are included with %license in %files (temporarily manually included from upstream)
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 5 Fedora Admin user for bugzilla script actions 2024-07-14 16:43:48 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-tracker-macros

Comment 6 Fedora Update System 2024-07-14 16:56:35 UTC
FEDORA-2024-37a5822fdf (rust-tracker-macros-0.2.1-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-37a5822fdf

Comment 7 Fedora Update System 2024-07-14 17:00:27 UTC
FEDORA-2024-37a5822fdf (rust-tracker-macros-0.2.1-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.