Bug 2292943

Summary:	Review Request: polylabel - A fast algorithm for finding the pole of inaccessibility of a polygon
Product:	[Fedora] Fedora	Reporter:	Tom Hughes <tom>
Component:	Package Review	Assignee:	Tom Rix <trix>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	package-review, trix
Target Milestone:	---	Keywords:	AutomationTriaged
Target Release:	---	Flags:	trix: fedora-review+
Hardware:	Unspecified
OS:	Unspecified
URL:	https://github.com/mapbox/polylabel/
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-07-05 16:01:18 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2275243

Description Tom Hughes 2024-06-18 17:46:02 UTC

Spec URL: https://tomh.fedorapeople.org/polylabel.spec
SRPM URL: https://tomh.fedorapeople.org/polylabel-1.1.0-1.fc40.src.rpm

Description:
A fast algorithm for finding polygon pole of inaccessibility, the most
distant internal point from the polygon outline.

Useful for optimal placement of a text label on a polygon.

Fedora Account System Username: tomh

Comment 1 Tom Hughes 2024-06-18 17:46:04 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=119249914

Comment 2 Fedora Review Service 2024-06-18 17:56:50 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7625356
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2292943-polylabel/fedora-rawhide-x86_64/07625356-polylabel/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Tom Rix 2024-07-05 13:11:43 UTC

Could update to v2.0.0 - came out this week.
Also add %dir %{_includedir}/mapbox to %files devel

Pretty simple header only package.
test passes

approved

Comment 4 Tom Hughes 2024-07-05 13:34:07 UTC

Thanks for the review.

I'll update the version but I'm not clear why you think adding %dir would be helpful? The directory is already added along with the files it contained and the only thing %dir does it to make rpm package the directory without any files it contains meaning they would then have to be listed separately, or is that what you're suggesting?

Comment 5 Fedora Admin user for bugzilla script actions 2024-07-05 13:37:23 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/polylabel

Comment 6 Tom Rix 2024-07-05 16:13:32 UTC

(In reply to Tom Hughes from comment #4)
> Thanks for the review.
> 
> I'll update the version but I'm not clear why you think adding %dir would be
> helpful? The directory is already added along with the files it contained
> and the only thing %dir does it to make rpm package the directory without
> any files it contains meaning they would then have to be listed separately,
> or is that what you're suggesting?

the fedora-review output had some (maybe spurious) warnings about dir ownership.
i have used the %dir squash these warnings in my own spec files.