Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://tomh.fedorapeople.org/polylabel.spec SRPM URL: https://tomh.fedorapeople.org/polylabel-1.1.0-1.fc40.src.rpm Description: A fast algorithm for finding polygon pole of inaccessibility, the most distant internal point from the polygon outline. Useful for optimal placement of a text label on a polygon. Fedora Account System Username: tomh
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=119249914
Copr build: https://copr.fedorainfracloud.org/coprs/build/7625356 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2292943-polylabel/fedora-rawhide-x86_64/07625356-polylabel/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Could update to v2.0.0 - came out this week. Also add %dir %{_includedir}/mapbox to %files devel Pretty simple header only package. test passes approved
Thanks for the review. I'll update the version but I'm not clear why you think adding %dir would be helpful? The directory is already added along with the files it contained and the only thing %dir does it to make rpm package the directory without any files it contains meaning they would then have to be listed separately, or is that what you're suggesting?
The Pagure repository was created at https://src.fedoraproject.org/rpms/polylabel
(In reply to Tom Hughes from comment #4) > Thanks for the review. > > I'll update the version but I'm not clear why you think adding %dir would be > helpful? The directory is already added along with the files it contained > and the only thing %dir does it to make rpm package the directory without > any files it contains meaning they would then have to be listed separately, > or is that what you're suggesting? the fedora-review output had some (maybe spurious) warnings about dir ownership. i have used the %dir squash these warnings in my own spec files.