Bug 2293138
| Summary: | Review Request: kf6-breeze-icons - Breeze icon theme framework | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Yaakov Selkowitz <yselkowi> | ||||
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | ngompa13, package-review | ||||
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://api.kde.org/frameworks/breeze-icons/html/ | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2024-06-25 02:26:53 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Yaakov Selkowitz
2024-06-19 21:57:26 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7628799 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2293138-kf6-breeze-icons/fedora-rawhide-x86_64/07628799-kf6-breeze-icons/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Taking this review. Spec review: > # trim changelog included in binary rpms > %global _changelog_trimtime %(date +%s -d "1 year ago") This is unnecessary as this is already globally set by redhat-rpm-config. Please drop this. > ## upstream patches (lookaside cache) We don't put patches in the lookaside anymore. Spec URL: https://yselkowitz.fedorapeople.org/kf6-breeze-icons.spec SRPM URL: https://yselkowitz.fedorapeople.org/kf6-breeze-icons-6.3.0-2.fc41.src.rpm Description: KDE Breeze icon theme framework Fedora Account System Username: yselkowitz Created attachment 2037818 [details]
The .spec file difference from Copr build 7628799 to 7628809
Copr build: https://copr.fedorainfracloud.org/coprs/build/7628809 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2293138-kf6-breeze-icons/fedora-rawhide-x86_64/07628809-kf6-breeze-icons/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Review notes: * Package follows Fedora Packaging Guidelines * Package correctly replaces existing breeze-icon-theme package * Package builds and installs * Package licensing data is correct PACKAGE APPROVED. FEDORA-2024-08b07d56c7 (kf6-breeze-icons-6.3.0-2.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-08b07d56c7 FEDORA-2024-08b07d56c7 (kf6-breeze-icons-6.3.0-2.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |