Bug 2293138 - Review Request: kf6-breeze-icons - Breeze icon theme framework
Summary: Review Request: kf6-breeze-icons - Breeze icon theme framework
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://api.kde.org/frameworks/breeze...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-06-19 21:57 UTC by Yaakov Selkowitz
Modified: 2024-06-25 02:26 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-06-25 02:26:53 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 7628799 to 7628809 (632 bytes, patch)
2024-06-19 22:25 UTC, Fedora Review Service
no flags Details | Diff

Description Yaakov Selkowitz 2024-06-19 21:57:26 UTC
Spec URL: https://yselkowitz.fedorapeople.org/kf6-breeze-icons.spec
SRPM URL: https://yselkowitz.fedorapeople.org/kf6-breeze-icons-6.3.0-2.fc41.src.rpm
Description: KDE Breeze icon theme framework
Fedora Account System Username: yselkowitz

This is a rename from breeze-icon-theme for https://pagure.io/fedora-kde/SIG/issue/530

Comment 1 Fedora Review Service 2024-06-19 22:04:33 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7628799
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2293138-kf6-breeze-icons/fedora-rawhide-x86_64/07628799-kf6-breeze-icons/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Neal Gompa 2024-06-19 22:13:18 UTC
Taking this review.

Comment 3 Neal Gompa 2024-06-19 22:15:37 UTC
Spec review:

> # trim changelog included in binary rpms
> %global _changelog_trimtime %(date +%s -d "1 year ago")

This is unnecessary as this is already globally set by redhat-rpm-config. Please drop this.

> ## upstream patches (lookaside cache)

We don't put patches in the lookaside anymore.

Comment 4 Yaakov Selkowitz 2024-06-19 22:19:09 UTC
Spec URL: https://yselkowitz.fedorapeople.org/kf6-breeze-icons.spec
SRPM URL: https://yselkowitz.fedorapeople.org/kf6-breeze-icons-6.3.0-2.fc41.src.rpm
Description: KDE Breeze icon theme framework
Fedora Account System Username: yselkowitz

Comment 5 Fedora Review Service 2024-06-19 22:25:32 UTC
Created attachment 2037818 [details]
The .spec file difference from Copr build 7628799 to 7628809

Comment 6 Fedora Review Service 2024-06-19 22:25:34 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7628809
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2293138-kf6-breeze-icons/fedora-rawhide-x86_64/07628809-kf6-breeze-icons/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Neal Gompa 2024-06-20 05:54:24 UTC
Review notes:

* Package follows Fedora Packaging Guidelines
* Package correctly replaces existing breeze-icon-theme package
* Package builds and installs
* Package licensing data is correct

PACKAGE APPROVED.

Comment 8 Fedora Update System 2024-06-21 04:14:38 UTC
FEDORA-2024-08b07d56c7 (kf6-breeze-icons-6.3.0-2.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-08b07d56c7

Comment 9 Fedora Update System 2024-06-25 02:26:53 UTC
FEDORA-2024-08b07d56c7 (kf6-breeze-icons-6.3.0-2.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.