Bug 2293850

Copr build:
https://copr.fedorainfracloud.org/coprs/eclipseo/gotests/build/7654972/
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/eclipseo/gotests/fedora-rawhide-x86_64/07654972-golang-github-hamba-avro2/fedora-review/review.txt

Please take a look if any issues were found.

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7655028
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2293850-golang-github-hamba-avro2/fedora-rawhide-x86_64/07655028-golang-github-hamba-avro2/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

I would like to understand better this package.

- Is it required by other package? I see no `gometa -f` is used, so it may be required by other package, but unclear which one.
- If the package is required by others, would it be better to make it a source only package? That way is easier to track if it's a leave package in the future.
- Is the package binary only? if so, why not add `gometa -f` and remove `gopkginstall` and `gopkgfiles`

> Is it required by other package?

Yes, that's why no -f

https://github.com/apache/arrow/blob/main/go/go.mod

We have two binaries described in : https://github.com/hamba/avro?tab=readme-ov-file#go-structs-generation

But yeah this is optonal.

Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-hamba-avro2.spec
SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-hamba-avro2-2.22.1-1.fc40.src.rpm

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7693831
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2293850-golang-github-hamba-avro2/fedora-rawhide-x86_64/07693831-golang-github-hamba-avro2/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Copr build:
https://copr.fedorainfracloud.org/coprs/eclipseo/gotests/build/7693830/
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/eclipseo/gotests/fedora-rawhide-x86_64/07693830-golang-github-hamba-avro2/fedora-review/review.txt

Please take a look if any issues were found.

This package was generated using go2rpm, which simplifies the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [x] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [x] There are no `%{_bindir}/*` wildcards in %files.
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance

Thanks!

The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-hamba-avro2

*** Bug 2318648 has been marked as a duplicate of this bug. ***